gitaly-ruby sidecar is not killed when specs exit
After a couple of days, I'm up to > 80 of these processes running.
The named sockets are gone, so if nothing else, gitaly-ruby could detect its own socket being unlinked and kill itself, but better would be to ensure the child dies with the parent.
I don't know if a sidecar is left behind every execution, or just aborted ones. If the latter, we can fix this by trapping signals sent to the parent and sending them to the child as well. KILL will leave children around, but TERM, INT, etc, will behave as expected. That's more than good enough.
Edited by Nick Thomas