Remove `CreateTriggerRequestService` and forbid to persist variables on Ci::TriggerRequest
The following discussion from !13102 (merged) should be addressed:
-
@godfat commented on a discussion: (+10 comments) Oh perhaps we should use
create!
too
We have the following code
module Ci
class TriggerRequest < ActiveRecord::Base
...
serialize :variables
...
end
end
We will completely switch to Ci::PipelineVariable
from Ci::TriggerRequest.variables
. This will be accomplished at https://gitlab.com/gitlab-org/gitlab-ce/issues/35623. After that we want to forbid to persist variables on Ci::TriggerRequest
. We want to make sure that we don't go back to the old way.
Edited by Shinya Maeda