Remove `service: true` from `spec/services/*_spec.rb`
The following discussion from !13102 (merged) should be addressed:
-
@godfat started a discussion: (+2 comments) @rymai Although we have
services: true
in a number of places, I don't see that we have services specific helper? I also see that RSpec has:Request specs reside in the spec/requests directory. The directory can also be named integration or api.
Perhaps we don't need this either:
config.define_derived_metadata(file_path: %r{/spec/requests/(ci/)?api/}) do |metadata| metadata[:api] = true end
Maybe just change
config.include ApiHelpers, :api
to:
config.include ApiHelpers, :request
Could be sufficient? Of course, all
api: true
would need to be changed torequest: true
though, which might hurt readability. I just feel that we could omit most of thexxx: true
and that would be much more cleaner.