HTML bug when rendering a patch
Summary
Here's what I saw in my merge request patch view today:
Requirements.txt never contained HTML code.
Steps to reproduce
Not sure to be honest. Please tell me specific git commands that would provide you with more information.
What is the current bug behavior?
HTML seems to leak into the table.
What is the expected correct behavior?
HTML should not leak into the table.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 8.8 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.13.0 Sidekiq Version:5.0.0 Go Version: unknownGitLab information
Version: 9.3.0
Revision: acb7f25
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: https://gitlab.edited.com
HTTP Clone URL: https://gitlab.edited.com/some-group/some-project.git
SSH Clone URL: ssh://git@gitlab.edited.com/some-group/some-project.git
Using LDAP: no
Using Omniauth: noGitLab Shell
Version: 5.0.5
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks
Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.0.5 ? ... OK (5.0.5) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 3/2 ... ok 3/3 ... ok 3/4 ... ok 3/5 ... ok 3/7 ... ok 3/8 ... ok 3/9 ... ok 3/10 ... ok 3/11 ... ok 1/14 ... ok 3/15 ... ok 3/16 ... ok 3/17 ... ok 3/18 ... ok 3/19 ... ok 9/20 ... ok 3/21 ... ok 3/22 ... ok 3/23 ... repository is empty 3/24 ... ok 1/25 ... ok 3/26 ... ok 15/27 ... ok 15/28 ... ok 15/29 ... ok 15/30 ... ok 3/31 ... ok 15/32 ... ok 3/33 ... ok 3/34 ... ok 3/35 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... no Try fixing it: sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ; sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ; For more information see: doc/install/installation.md in section "GitLab" Please fix the error above and rerun the checks. Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/2 ... yes 3/3 ... yes 3/4 ... yes 3/5 ... yes 3/7 ... yes 3/8 ... yes 3/9 ... yes 3/10 ... yes 3/11 ... yes 1/14 ... yes 3/15 ... yes 3/16 ... yes 3/17 ... yes 3/18 ... yes 3/19 ... yes 9/20 ... yes 3/21 ... yes 3/22 ... yes 3/23 ... yes 3/24 ... yes 1/25 ... yes 3/26 ... yes 15/27 ... yes 15/28 ... yes 15/29 ... yes 15/30 ... yes 3/31 ... yes 15/32 ... yes 3/33 ... yes 3/34 ... yes 3/35 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.3) Git version >= 2.7.3 ? ... yes (2.13.0) Active users: ... 8
Checking GitLab ... Finished
Possible fixes
No idea.
en