Skip to content

I18N - gitlab.pot --> does it belong in the repo, or should it be .gitignore?

Summary

The current HEAD of the master branch includes locale/gitlab.pot which at present moment only contains default contents generated during the launch of the GDK.

As a build artifact, does it belong in the repository?

Steps to reproduce

  1. install gitlab GDK
  2. gdk reconfigure -> (replaces locale/gitlab.pot with new contents)
  3. git status -> (shows locale/gitlab.pot which only contains a diff with date/time stamps)

What is the current bug behavior?

  1. git diff locale/gitlab.pot contains:
8	8	 msgstr ""
9	9	 "Project-Id-Version: gitlab 1.0.0\n"
10	10	 "Report-Msgid-Bugs-To: \n"
11	         -"POT-Creation-Date: 2017-05-04 19:24-0500\n"
12	         -"PO-Revision-Date: 2017-05-04 19:24-0500\n"
11	         +"POT-Creation-Date: 2017-05-24 19:07+0800\n"

What is the expected correct behavior?

file should not be included in repository unless it has relevant persistent state.

Possible fixes

  1. git rm "locale/gitlab.pot"
  2. echo "locale/gitlab.pot" > .gitignore

Related

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11573#note_30852818