Skip to content

Configurable defaults for "Remove source branch" on merge requests

In https://gitlab.com/gitlab-org/gitlab-ce/issues/14413 the default behavior was changed to enable Remove source branch by default when creating new merge requests. This is good for some workflows but is also problematic for others. We should make the default value configurable so that teams can chose the option that is right for them.

Proposal

Add a new option to the project Merge request settings for controlling the default.

There should be two options:

  • Default: Enabled - when creating a new merge request, Remove source branch will be checked
  • Default: Disabled - when creating a new merge request, Remove source branch will be unchecked

For new and existing projects the default value of the setting should be Default: Disabled

Mockup
20180713_screenshot_7

Future improvements:

  • add option to configure at Group and Instance level

Links / references

#14413 (closed)

Original request

Description

Per #14413 (closed) MR now have 'remove source branch' set as a default... This is not good for EVERY workflow, but clearly good for a subset that knew about this ticket prior to release. This needs to be configurable. Not every team even with my org can keep this as the default.

Proposal

Make 'remove source branch' for MRs checkbox DEFAULT to off. Make 'remove source branch' for MRs globally configurable. Make 'remove source branch' for MRs group configurable. AND Make 'remove source branch' for MRs project configurable.

Edited by James Ramsay (ex-GitLab)