Marking task changed in issue causes message about description changing
Summary
In an issue, marking a task complete generates both a message saying "So-and-so marked the task Foobar as completed" and also a message saying "So-and-so changed the description". The second message is redundant and was not present in previous versions of Gitlab.
Steps to reproduce
- Create an issue with a task list
- Mark a task complete
What is the current bug behavior?
Redundant "changed the description" message appears in issue log.
What is the expected correct behavior?
Only the message "marked the task X as completed" should appear.
Relevant logs and/or screenshots
Example on Gitlab.com itself: https://gitlab.com/gitlab-org/gitlab-ce/issues/32711#note_30505978
Output of checks
This bug happens on GitLab.com and community.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.11.1 Sidekiq Version:5.0.0GitLab information Version: 9.2.0 Revision: 27cff7d Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.XXX.net HTTP Clone URL: https://gitlab.XXX.net/some-group/some-project.git SSH Clone URL: git@gitlab.XXX.net:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.0.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.0.3 ? ... OK (5.0.3) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 19/99 ... ok 20/101 ... ok 20/102 ... ok 20/103 ... ok 20/104 ... ok 20/105 ... ok 21/106 ... ok 21/108 ... ok 21/109 ... ok 21/110 ... ok 21/112 ... ok 21/114 ... ok 21/115 ... ok 21/117 ... ok 19/118 ... ok 21/119 ... ok 21/120 ... ok 21/121 ... ok 7/122 ... ok 21/123 ... ok 21/124 ... repository is empty Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
IMAP server credentials are correct? ... yes Init.d configured correctly? ... skipped (omnibus-gitlab has no init script) MailRoom running? ... can't check because of previous errors
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config outdated? ... no Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory setup correctly? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) projects have namespace: ... 19/99 ... yes 20/101 ... yes 20/102 ... yes 20/103 ... yes 20/104 ... yes 20/105 ... yes 21/106 ... yes 21/108 ... yes 21/109 ... yes 21/110 ... yes 21/112 ... yes 21/114 ... yes 21/115 ... yes 21/117 ... yes 19/118 ... yes 21/119 ... yes 21/120 ... yes 21/121 ... yes 7/122 ... yes 21/123 ... yes 21/124 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.1.0 ? ... yes (2.3.3) Your git bin path is "/opt/gitlab/embedded/bin/git" Git version >= 2.7.3 ? ... yes (2.11.1) Active users: 8
Checking GitLab ... Finished
Possible fixes
Revert to pre-9.2 behavior.