Skip to content

2-up image diff does not initially show file size and image dimensions

Summary

The the initial MR diff view for modified images does not show file size and image dimensions

Steps to reproduce

  1. Commit a change to an image: git ls-files -z '*.png' | xargs -0 mogrify && git commit -a -m "Optimize images"
  2. Push to a branch
  3. Create a merge request

What is the current bug behavior?

You first see this:

image

Then if you switch to another image diff view like swipe you see this:

image

Then if you switch back to 2-up view you see this:

image

What is the expected correct behavior?

I expect to see this for the 2-up view from the start:

image

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 16.04
Current User:   git
Using RVM:      no
Ruby Version:   2.3.3p222
Gem Version:    2.6.6
Bundler Version:1.13.7
Rake Version:   10.5.0
Redis Version:  3.2.5
Git Version:    2.11.1
Sidekiq Version:4.2.7

GitLab information
Version:        9.1.2
Revision:       df1403f
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
URL:            http://gitlab
HTTP Clone URL: http://gitlab/some-group/some-project.git
SSH Clone URL:  git@gitlab:some-group/some-project.git
Using LDAP:     yes
Using Omniauth: no


GitLab Shell
Version:        5.0.2
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...

GitLab Shell version >= 5.0.2 ? ... OK (5.0.2)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
4/2 ... ok
4/3 ... ok
4/4 ... ok
2/5 ... ok
3/7 ... ok
3/8 ... ok
4/9 ... ok
8/10 ... ok
2/11 ... repository is empty
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Reply by email ...


Reply by email is disabled in config/gitlab.yml


Checking Reply by email ... Finished


Checking LDAP ...


Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)



Checking LDAP ... Finished


Checking GitLab ...


Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
4/2 ... yes
4/3 ... yes
4/4 ... yes
2/5 ... yes
3/7 ... yes
3/8 ... yes
4/9 ... yes
8/10 ... yes
2/11 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.11.1)
Active users: 7


Checking GitLab ... Finished