Add function to hunk header on email on push diff
- Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/9139
- Dev link: None
- GitLab version: Unknown
Currently, email on push diffs do not show the function name in the hunk header. Also, the diff generator does not seem to honor a .gitattributes
setting like *.m diff=objc
. libgit2
supports this type of configuration and it would be nice if the email on push would honor this, too.
Current Result:
--- a/VideoCaptureDemo/ViewController.m
+++ b/VideoCaptureDemo/ViewController.m
@@ -55,14 +55,6 @@
[self presentViewController:viewController animated:YES completion:nil];
break;
}
- case 3:
- {
- UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"Main" bundle:nil];
- IDCaptureSessionPipelineViewController *viewController = [storyboard instantiateViewControllerWithIdentifier:@"captureSessionVC"];
- [viewController setupWithPipelineMode:PipelineModeAssetWriter];
- [self presentViewController:viewController animated:YES completion:nil];
- break;
- }
default:
break;
}
Expected result:
--- a/VideoCaptureDemo/ViewController.m
+++ b/VideoCaptureDemo/ViewController.m
@@ -55,6 +55,14 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath
[self presentViewController:viewController animated:YES completion:nil];
break;
}
+ case 3:
+ {
+ UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"Main" bundle:nil];
+ IDCaptureSessionPipelineViewController *viewController = [storyboard instantiateViewControllerWithIdentifier:@"captureSessionVC"];
+ [viewController setupWithPipelineMode:PipelineModeAssetWriter];
+ [self presentViewController:viewController animated:YES completion:nil];
+ break;
+ }
default:
break;
}
Next steps
If we're just using gitlab_git
to generate diffs, which passes all the way down to libgit2
then why is the .gitattribute
setting not honored? How hard will it be to make this work?
/cc @JobV