Authorizing a twitter account on multiple GitLab accounts gives an wrong message
Summary
If a user connected their twitter account to username1, then later tried to connect that same twitter account to username2, they are given the wrong confirmation message.
Steps to reproduce
-
Log in to GitLab and go to Profile Settings > Account
-
By 'Social Sign-in', connect to twitter
-
If needed, log in to twitter and click 'Authorize'
-
You will be taken back to Profile Settings > Account where you now have the option to disconnect twitter
-
Log out and log in with another GitLab username
-
Go to Profile Settings > Account
-
By 'Social Sign-in', connect to twitter
-
If needed, log in to twitter and click 'Authorize'
-
You will be taken back to Profile Settings > Account where you now still have the option to connect to twitter. The flash message, however, reads 'Authentication method updated'
Expected behavior
The flash message should provide a clear explanation of what happened, and that the username is not available to connect because it is connected to another account.
Actual behavior
The flash message reads 'Authentication method updated'