Clean up JiraService
Problems
-
JiraServicenever works when it's executed as a hook (see #24940 (closed)), we always call it directly -
executemethod in project services is meant to be executed by project hooks - we use
JiraService#supported_eventsto render correct options for configuring JIRA integration ("Trigger") in service settings screen, but we do not really support these events as project hooks
Proposal
-
JiraService#executeshould be a no-op - override
Service#testinJiraServiceso it callsJiraService#test_settingsinstead ofJiraService#execute - extract a separate method from
JiraService#executewhich will be called fromIssues::CloseService#close_issue
This will fix #24777 (closed) and #24948 (closed).