Skip to content

test failure: allow for precompiled assets when testing.

I'm running tests for gitlab installed via native debian package (8.11.3). First two failures seems easy to fix. Third on could be because of a newer version of addressable. This is the current state of dependencies http://debian.fosscommunity.in/status/?appname=gitlab8.11.3&sorted=satisfied

$ sudo -u gitlab -E -H bundle exec rspec spec/lib/banzai/
Error deleting useless .secret file: Permission denied @ unlink_internal - /usr/share/gitlab/.secret
DEPRECATION WARNING: Sprockets method `register_engine` is deprecated.
Please register a mime type using `register_mime_type` then
use `register_compressor` or `register_transformer`.
https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors
 (called from block (2 levels) in <class:Railtie> at /usr/lib/ruby/vendor_ruby/sass/rails/railtie.rb:57)
DEPRECATION WARNING: Sprockets method `register_engine` is deprecated.
Please register a mime type using `register_mime_type` then
use `register_compressor` or `register_transformer`.
https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors
 (called from block (2 levels) in <class:Railtie> at /usr/lib/ruby/vendor_ruby/sass/rails/railtie.rb:58)
..................................................................................F.F.............................................................................................................................................................................................................................................................................F................................................................................................................................................................................................................................................

Failures:

  1) Banzai::Filter::EmojiFilter replaces supported emoji
     Failure/Error: expect(doc.css('img').first.attr('src')).to eq 'https://foo.com/assets/2764.png'

       expected: "https://foo.com/assets/2764.png"
            got: "https://foo.com/assets/2764-92be652ec3e50c6e7393440b5d52b88a367f98a28dffe12660095ed3253aa6c0.png"

       (compared using ==)
     # ./spec/lib/banzai/filter/emoji_filter_spec.rb:17:in `block (2 levels) in <top (required)>'

  2) Banzai::Filter::EmojiFilter correctly encodes the URL
     Failure/Error: expect(doc.css('img').first.attr('src')).to eq 'https://foo.com/assets/1F44D.png'

       expected: "https://foo.com/assets/1F44D.png"
            got: "https://foo.com/assets/1F44D-59ec2457ab33e8897261d01a495f6cf5c668d0004807dc541c3b1be5294b1e61.png"

       (compared using ==)
     # ./spec/lib/banzai/filter/emoji_filter_spec.rb:28:in `block (2 levels) in <top (required)>'

  3) Banzai::Filter::SanitizationFilter custom whitelist disallows protocol whitespace
     Failure/Error: expect(doc.to_html).to eq data[:output]

       expected: "<a href=\"http://example.com/\"></a>"
            got: "<a></a>"

       (compared using ==)
     # ./spec/lib/banzai/filter/sanitization_filter_spec.rb:178:in `block (4 levels) in <top (required)>'

Finished in 5 minutes 4 seconds (files took 9.27 seconds to load)
595 examples, 3 failures

Failed examples:

rspec ./spec/lib/banzai/filter/emoji_filter_spec.rb:15 # Banzai::Filter::EmojiFilter replaces supported emoji
rspec ./spec/lib/banzai/filter/emoji_filter_spec.rb:26 # Banzai::Filter::EmojiFilter correctly encodes the URL
rspec ./spec/lib/banzai/filter/sanitization_filter_spec.rb[1:2:22] # Banzai::Filter::SanitizationFilter custom whitelist disallows protocol whitespace

pravi@nishumbha:/usr/share/gitlab$