New issue button redirects you to create a new issue after logging in

Resources

PM @victorwu | UX @hazelyang | FE @samrose3

Description

• The 'New issue' button should be visible even if you aren't logged in.
• Clicking the 'New issue' button should prompt you to log in, and then, if successful, take you to the new issue page.
• Banner message on the sign in page:

Original description

In gitlab instances with Sign up or user creation through external auth provider enabled, please change the UI to show "New Issue" button on public bugtrackers on the main gitlab-hostname.com/username/repo/issues/ listing page even when logged out, as a non-primary action button looking as suggested in the following mockup image (image originates from ticket #20186 (closed)):

Currently, the issues page to which I'm sending users to report bugs looks like there's nothing that can be done as a random visitor, and the "Sign in" button seems more like a private member account kind of thing rather than an invitation to create a new account and participate. Therefore, a visible "New Issue" button that signals even to anonymous logged-out visitors that they can possibly participate and which simply redirects to the login and sign-up page would be much more intuitive in signalling that indeed any public user is invited to make an account and file an issue.

Changed title: In gitlab instances with Sign up or user creation through external auth provider enabled, show "New Issue" button on public bugtrackers even when logged out → In gitlab instances with Sign up or user creation through external auth provider enabled, to show "New Issue" button on public bugtrackers even when logged out

Added ~14281 ~19492 ~14213 labels

Changed title: In gitlab instances with Sign up or user creation through external auth provider enabled, to show "New Issue" button on public bugtrackers even when logged out → In gitlab instances with Sign up or user creation through external auth provider enabled, show "New Issue" button on public bugtrackers even when logged out

mentioned in issue #26459 (closed)

@tauriedavis Please could you take a look at this issue? Do you think that we should show the "New Issue" button to non-authenticated users? They would be redirected to the login page before they could actually create an issue. Thanks!

Since we encourage users to make new issues, I would say yes - we should show the "New issue" button even when users are not logged in. After they sign in, they should be directed to the new issue page. cc @awhildy

Agreed. Thanks @tauriedavis!

mentioned in issue #23949 (closed)

mentioned in issue #27995 (closed)

added ~423634 label

Related issue:

• https://gitlab.com/gitlab-org/gitlab-ce/issues/27829

@victorwu - This is something we should do.

added ~874211 ~127616 ~974571 and removed ~19492 labels

changed milestone to %29

@smcgivern : Can this be done by a frontend person only?

@victorwu I think so, although I'm not sure how easy it is to check if external providers for sign-up are enabled from a view. I don't think it would be too hard.

The design should be consistent with other scenarios, such as https://gitlab.com/gitlab-org/gitlab-ce/issues/28899, so that we can quickly take these ideas and apply them to different parts of GitLab.

mentioned in issue #28899 (closed)

changed milestone to %9.1

changed title from In gitlab instances with Sign up or user creation through external auth provider enabled, show "New Issue" button on public bugtrackers even when logged out to New issue button redirects you to create a new issue after logging in

created branch 20204-new-issue-button-redirects-you-to-create-a-new-issue-after-logging-in

Thanks @samrose3 for jumping onto this. @hazelyang is designing this one and https://gitlab.com/gitlab-org/gitlab-ce/issues/28899 as they are very similar.

@MadLittleMods: I see you and/or @jschatz1 put your name onto https://gitlab.com/gitlab-org/gitlab-ce/issues/28899. Feel free to reference this one here as well. Thanks!

mentioned in merge request !9743 (merged)

assigned to @hazelyang

mentioned in issue #19574 (closed)

closed via merge request !9743 (merged)

mentioned in commit innerwhisper/gitlab-ce@85759f2c

@hazelyang : Can you review this. Does this need a banner message at any stage of the redirection. I.e. when the user is redirected to the login page, and after they login and are redirected to the new issue page.

cc @tauriedavis

@victorwu I added a banner on the sign in / Register page.

Flow

1. Click "New issue" button
2. A banner message is showing on sign in / register page
3. Enter username/password and then click "Sign in"
4. New issue page

@samrose3 : Sorry for not getting this to you earlier. Could we add the banner message on the sign in page as part of the flow? Thanks! https://gitlab.com/gitlab-org/gitlab-ce/issues/20204#note_25858393

reopened

@victorwu not a problem I'll get another MR going and have it in soon

assigned to @samrose3

created branch 20204-new-issue-button-redirects-you-to-create-a-new-issue-after-logging-in

mentioned in merge request !10143 (merged)

closed via merge request !10143 (merged)

Thanks @samrose3 !

This merge was an accident. Wasn't quit implemented yet. Reopening

reopened

mentioned in merge request !10153 (merged)

closed via merge request !10153 (merged)

mentioned in commit 02810094

added devopsplan label