500 error on uploads for special filenames (test%20%85.pdf)
Summary
When uploading a file via notes with a filename such as "test%20%85.pdf", it will result in a 500 error and no creation or upload at all.
Steps to reproduce
Attach a file with the filename "test%20%85.pdf" to a note and try to add/upload it.
Expected behavior
Add note and upload the attachment.
Observed behavior
500 internal server error.
Relevant logs
Could not find relevant logs yet.
Output of checks
No errors (all green)
Checking Environment ...
Git configured for git user? ... yes
Checking Environment ... Finished
Checking GitLab Shell ...
GitLab Shell version >= 2.5.3 ? ... OK (2.5.3)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
Satellites access is drwxr-x---? ... yes
hooks directories in repos are links: ...
2/1 ... ok
[...]
2/174 ... ok
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
/var/git/repositories: OK
/home/git/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 2.8.4
Send ping to redis server: PONG
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ...
2/1 ... yes
[...]
2/174 ... yes
Projects have satellites? ...
2/1 ... yes
[...]
2/174 ... yes
Redis version >= 2.0.0? ... yes
Ruby version >= 2.0.0 ? ... yes (2.1.5)
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.9.1)
Checking GitLab ... Finished
Gitlab Version
7.8.0-ee bcc8dbd0 Sidenote: Reproducable with gitlab.com (7.8.0-ee 27251058)