GitLab FOSS issueshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues2019-09-11T11:33:08Zhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/51520Send email notification for changing milestone on issues and merge requests2019-09-11T11:33:08ZVictor Wuvictor@gitlab.comSend email notification for changing milestone on issues and merge requestsSend an email notification for a changing milestone. This includes:
- Adding a milestone.
- Removing a milestone.
- Changing from one to another milestone.
Applies to issues and merge requests.
### Notification level settings
- This sh...Send an email notification for a changing milestone. This includes:
- Adding a milestone.
- Removing a milestone.
- Changing from one to another milestone.
Applies to issues and merge requests.
### Notification level settings
- This should apply at the same level as changing assignees and labels. So that means this will be sent for the Participant level and Watch levels. See https://docs.gitlab.com/ee/workflow/notifications.html.
- For this issue, we will _not_ add this to the custom notification settings.
### Design
Email copy:
- Adding a milestone: `Milestone changed to **11.5**`
- Removing a milestone: `Milestone removed`
- Changing from one milestone to another milestone: `Milestone changed to **11.5**`
- The milestone name should be a link to the milestone page.11.5Annabel Dunstone GrayChantal RollisonAnnabel Dunstone Grayhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/50848Milestone count is missing group milestones2019-08-07T08:20:35ZRonald van Zonrvanzon@gitlab.comMilestone count is missing group milestones### Summary
Moving a Milestone into a group will remove it from the count in the Milestones overview.
### Steps to reproduce
![moving_milestone](/uploads/fddd10569aa6bbaf654f29fe6a828c07/moving_milestone.gif)
### What is the current ...### Summary
Moving a Milestone into a group will remove it from the count in the Milestones overview.
### Steps to reproduce
![moving_milestone](/uploads/fddd10569aa6bbaf654f29fe6a828c07/moving_milestone.gif)
### What is the current *bug* behavior?
The count doesn't represent the correct number
### What is the expected *correct* behavior?
See the correct number in the counts.11.5Ronald van Zonrvanzon@gitlab.comRonald van Zonrvanzon@gitlab.comhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/54139Cannot add milestone to an issue directly from a board2021-11-08T16:17:26ZNicoCannot add milestone to an issue directly from a board### Summary
I can't assign a milestone to an issue directly from the Board view.
### Steps to reproduce
On an Issues Board, click on a card (note the title) to make the panel on the right appear. Click on "edit" in the milestone sectio...### Summary
I can't assign a milestone to an issue directly from the Board view.
### Steps to reproduce
On an Issues Board, click on a card (note the title) to make the panel on the right appear. Click on "edit" in the milestone section, select an existing milestone.
Note : It still works perfectly fine if I go into the detailed issue page and set the milestone from there.
### Example Project
https://gitlab.com/nicolus/milestone-from-issue-board-bug/boards
### What is the current *bug* behavior?
The spinning loader appears but never disappears.
There's an error in the javascript console : `TypeError: o is undefined; can't access its "detail" property`
If I reload the page, the issue is not affected to the milestone.
### What is the expected *correct* behavior?
The milestone should be added to the issue, and the loader should disappear.
### Relevant logs and/or screenshots
![ms-issue](/uploads/1293e9c4218d7634e6c308e705f3b95c/ms-issue.png)
### Output of checks
This bug happens on GitLab.com11.6Inactive AccountInactive Accounthttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/51301Promoting a milestone is missing an authorization check2019-09-05T22:05:25ZDennis AppeltPromoting a milestone is missing an authorization checkWe received a report from an external security research that the functionality for [promoting a milestone](https://docs.gitlab.com/ee/user/project/milestones/#promoting-project-milestones-to-group-milestones) is missing an authorization ...We received a report from an external security research that the functionality for [promoting a milestone](https://docs.gitlab.com/ee/user/project/milestones/#promoting-project-milestones-to-group-milestones) is missing an authorization check. The report can be found at https://hackerone.com/reports/406390. In summary, a project member in the guest role can promote a project milestone to a group milestone.
I could reproduce the reported behavior and believe it is a bug.
Please find the full report below.
---
```
Title: Guest role user can promote open milestones in project
Scope: *.gitlab.com
Weakness: Privilege Escalation
Severity: No Rating
Link: https://hackerone.com/reports/406390
Date: 2018-09-06 08:50:02 +0000
By: @sandeep_hodkasia
```
Details:
> NOTE! Thanks for submitting a report! Please replace *all* the [square] sections below with the pertinent details. Remember, the more detail you provide, the easier it is for us to triage and respond quickly, so be sure to take your time filling out the report!
**Summary:**
Guest role user can promote open milestones in project.
**Description:**
Guest role user were not allowed to either edit, create or delete milestone in project.
But privilege escalation on the vulnerable request allows guest role user to promote open milestone in project. And once the milestone is promoted it will available for all the projects inside the group and this process can't be reversed.
##Vulnerable request:
```
POST /sandeep01/test/milestones/4/promote HTTP/1.1
Host: gitlab.com
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
Accept: application/json, text/plain, */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: https://gitlab.com/sandeep01/test/milestones/4
X-CSRF-Token: xxxx
X-Requested-With: XMLHttpRequest
Cookie: xxxxx
Connection: close
Content-Length: 28
{"params":{"format":"json"}}
```
## Steps To Reproduce:
1. add new project in group.
2. Add guest member in project.
3. create new milestone in project.
4. Replay vulnerable request in burp suite using new guest role user session.
5. Change group name (sandeep01), project name (test) and milestone number (4) in the vulnerable with your account data.
6. HIT API
7. Milestone will be promoted.
## Impact
Guest role user can promote open milestones in project11.6https://gitlab.com/gitlab-org/gitlab-foss/-/issues/53933Include start date and end date in milestone changed notification email2019-01-09T10:26:41ZVictor Wuvictor@gitlab.comInclude start date and end date in milestone changed notification emailSo that user/customers on GitLab.com who care about GitLab CE/EE users can immediately see the dates without clicking through into GitLab itself.
![image](https://gitlab.com/gitlab-org/gitlab-ce/uploads/534491d98732465e49dc21c86a22b12f/...So that user/customers on GitLab.com who care about GitLab CE/EE users can immediately see the dates without clicking through into GitLab itself.
![image](https://gitlab.com/gitlab-org/gitlab-ce/uploads/534491d98732465e49dc21c86a22b12f/image.png)
- Start and due date: “Milestone changed to **[11.8](#)** (Jan 8 – Feb 22, 2019)”
- Only start date:
- Date in the future: “Milestone changed to **[11.8](#)** (starts on Feb 24, 2019)”
- Date in the past: “Milestone changed to **[11.8](#)** (started on Sep 3, 2018)”
- Only due date:
- Date in the future: “Milestone changed to **[11.8](#)** (expires on Jan 1, 2019)”
- Date in the past: “Milestone changed to **[11.8](#)** (expired on Oct 5, 2018)”
- No dates: “Milestone changed to **[11.8](#)**”11.7Pedro Moreira da SilvaHeinrich Lee Yuheinrich@gitlab.comPedro Moreira da Silvahttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/53907Improve Milestone links2019-08-07T08:28:50ZDimitrie HoekstraImprove Milestone links### Problem to solve
Currently, when mentioning a milestone link it displays as any other link (%"10.4"). This is different compared to for example a user/issue/mr mention.
### Further details
-
### Solution
Display milestone link...### Problem to solve
Currently, when mentioning a milestone link it displays as any other link (%"10.4"). This is different compared to for example a user/issue/mr mention.
### Further details
-
### Solution
Display milestone links like [%10.4](https://gitlab.com/groups/gitlab-org/-/milestones/4)
### What does success look like, and how can we measure that?
Milestone links are distinguishable from any other link
### Links / references11.7Pedro Moreira da SilvaHeinrich Lee Yuheinrich@gitlab.comPedro Moreira da Silvahttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/53655When an issue is moved from a custom board list to the "Open" board list the ...2021-11-08T16:17:32ZGeorge RedivoWhen an issue is moved from a custom board list to the "Open" board list the milestone of the is lost### Summary
Given I have an issue with Milestone field set and it is in an custom board list,
when I move that issue back to the "Open" board list (the default one) the Milestone of the issue is lost and the field become empty.
### St...### Summary
Given I have an issue with Milestone field set and it is in an custom board list,
when I move that issue back to the "Open" board list (the default one) the Milestone of the issue is lost and the field become empty.
### Steps to reproduce
1. Create an issue
2. Set a Milestone to it
3. Go to Issues board
4. Create a custom board list
5. Move the created issue to the custom board list
6. Move the issue back to "Open" board list (now the milestone is lost)
### Example Project
Example project: https://gitlab.com/redivo/board-bug-example
Buggy board: https://gitlab.com/redivo/board-bug-example/boards
Buggy issue: https://gitlab.com/redivo/board-bug-example/issues/3
### What is the current *bug* behavior?
The Milestone is removed from the issue when it goes from a custom board list to the "Open" board list.
### What is the expected *correct* behavior?
The Milestone of the issue is not changed when it goes from a custom board list to the "Open" board list. (except for the first edge case below).
### Edge cases
- When an issue is moved from a milestone list to the open list, the milestone _should_ be removed.
- When an issue is moved from a milestone list to the closed list, the milestone should _not_ be removed.
### Docs to update:
Update this table with the milestone list cases: https://docs.gitlab.com/ee/user/project/issue_board.html#dragging-issues-between-lists
### Relevant logs and/or screenshots
N/A
### Output of checks
This bug happens on GitLab.com
#### Results of GitLab environment info
N/A
#### Results of GitLab application Check
N/A
### Possible fixes
N/A11.7Jarka Košanovájarka@gitlab.comJarka Košanovájarka@gitlab.comhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/52376[Frontend] Add project milestone links to dashboard milestones page2019-08-07T08:19:47ZAndré Luísaluis@gitlab.com[Frontend] Add project milestone links to dashboard milestones pageFrontend Issue for: https://gitlab.com/gitlab-org/gitlab-ce/issues/49289
Please refer to <a href="https://gitlab.com/gitlab-org/gitlab-ce/issues/49289">the description of the parent issue</a> for up-do-date information.
This issue was ...Frontend Issue for: https://gitlab.com/gitlab-org/gitlab-ce/issues/49289
Please refer to <a href="https://gitlab.com/gitlab-org/gitlab-ce/issues/49289">the description of the parent issue</a> for up-do-date information.
This issue was created to track Frontend weight independently of Backend.11.7Fatih AcetFatih Acethttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/49289Add project milestone links to dashboard milestones page2019-08-07T08:21:19ZVictor Wuvictor@gitlab.comAdd project milestone links to dashboard milestones pageBefore we deprecate the dynamic milestone list items from the dashboard page (https://gitlab.com/gitlab-org/gitlab-ce/issues/39545), we should add direct project milestone links to the dashboard page.
This issue does that.
That is, on...Before we deprecate the dynamic milestone list items from the dashboard page (https://gitlab.com/gitlab-org/gitlab-ce/issues/39545), we should add direct project milestone links to the dashboard page.
This issue does that.
That is, on the dashboard milestone page (e.g. https://gitlab.com/dashboard/milestones), we should have a link that goes directly to https://gitlab.com/victorwu/hello-world3/milestones/1, as an example.
The design is the same as how group milestones currently are displayed on the dashboard milestones list. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22552#note_113560124.
**Frontend issue:** https://gitlab.com/gitlab-org/gitlab-ce/issues/5237611.7Annabel Dunstone GrayFelipe ArturFatih AcetAnnabel Dunstone Grayhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/56764Poor UI on Milestone validation error page2019-09-21T05:57:17ZTakuya NoguchiPoor UI on Milestone validation error page### Summary
UI on Milestone validation error page is broken.
### Steps to reproduce
1. Go to the new milestone page (for a GitLab Team member e.g., https://gitlab.com/gitlab-org/gitlab-ce/milestones/new).
1. Input invalid values in th...### Summary
UI on Milestone validation error page is broken.
### Steps to reproduce
1. Go to the new milestone page (for a GitLab Team member e.g., https://gitlab.com/gitlab-org/gitlab-ce/milestones/new).
1. Input invalid values in the form (the same title with existing Milestone's one, the same date for Start Date and Due Date) and submit it.
1. You will see the broken Web UI on validation error page.
### Example Project
Any project including https://gitlab.com/gitlab-org/gitlab-ce
### What is the current *bug* behavior?
Labels with violating the validations are misaligned (see the screenshot as below).
### What is the expected *correct* behavior?
Labels with violating the validations should be aligned as well as other labels.
### Relevant logs and/or screenshots
#### Project Milestone
![milestone-error-page](/uploads/be821c6948a7889da56757e599668e66/milestone-error-page.png)
#### Group Milestone
![group-milestone-before](/uploads/afda62ec2f2cf95882b61f1b356bbe8f/group-milestone-before.png)
### Output of checks
This bug happens on GitLab.com (11.7.0-ee).
### Possible fixes
Fix CSS classes in related HAML files.11.8Takuya NoguchiTakuya Noguchi2019-02-07https://gitlab.com/gitlab-org/gitlab-foss/-/issues/57663Milestones dashboard is giving 500 on GitLab.com2019-08-07T08:18:02ZVictor Wuvictor@gitlab.comMilestones dashboard is giving 500 on GitLab.comAccessing dashboard milestones is causing a statement timeout.
```
ActiveRecord::StatementInvalidDashboard::MilestonesController#index
errorPG::QueryCanceled: ERROR: canceling statement due to statement timeout : SELECT COUNT(*) AS cou...Accessing dashboard milestones is causing a statement timeout.
```
ActiveRecord::StatementInvalidDashboard::MilestonesController#index
errorPG::QueryCanceled: ERROR: canceling statement due to statement timeout : SELECT COUNT(*) AS count_all,
"milestones"."state" AS milestones_state FROM "milestones" WHERE ("milestones"."project_id" IN (SELECT
"projects"."id" FROM "projects" INNER JOIN "project_authorizations" ON "projects"."id" =
"project_authorizations"."project_id" WHERE "project_authorizations"."user_id" = 3506051 AND "projects"."archived" =
'f' ORDER BY GREATEST(COALESCE(last_activity_at, '1970-01-01'), COALESCE(last_repository_updated_at, '1970-01-01'))
DESC) OR "milestones"."group_id" IN (SELECT "id" FROM (WITH RECURSIVE "base_and_ancestors" AS (SELECT "namespaces".*
FROM (SELECT "namespaces".* FROM "namespaces" INNER JOIN "members" ON "namespaces"."id" = "members"."source_id" WHERE
"members"."source_type" = 'Namespace' AND "namespaces"."type" IN ('Group') AND "members"."user_id" = 3506051 AND
"members"."type" IN ('GroupMember') AND "members"."requested_at" IS NULL UNION SELECT namespaces.* FROM "projects"
INNER JOIN "namespaces" ON "n...ruby
```
More information(internal use only):
https://sentry.gitlab.net/gitlab/gitlabcom/issues/648450/?query=is:unresolved
May be related to: https://gitlab.com/gitlab-org/gitlab-ce/issues/4303911.9Felipe ArturFelipe Arturhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/54789Project Milestones are visible when issues are project member only in public ...2019-08-07T08:19:03ZGitLab SecurityBotProject Milestones are visible when issues are project member only in public projects**[HackerOne report #452074](https://hackerone.com/reports/452074)** by ashish_r_padelkar on 2018-11-29:
**Summary:**
Hello,
I see this `https://gitlab.com/-/boards/&lt;BoardID&gt;/milestones.json` endpoint is fixed ( i reported dupli...**[HackerOne report #452074](https://hackerone.com/reports/452074)** by ashish_r_padelkar on 2018-11-29:
**Summary:**
Hello,
I see this `https://gitlab.com/-/boards/<BoardID>/milestones.json` endpoint is fixed ( i reported duplicate here #447992 .However, there is one more endpoint which reveals all the milestones for similar settings.
`https://gitlab.com/<Group>/<project>/autocomplete_sources/milestones`
**Description:**
When project is public and issues are set as `Only Project Members`, the issue tab is not visible publicly. `Milestone` tab is a sub menu of issues so it expected that milestones too are protected from public.
However, when you use quick actions in comments `/milestone %milestone` the following request is sent in backend
`https://gitlab.com/<Group>/<project>/autocomplete_sources/milestones`
This reveals all the milestones from projects!
## Steps To Reproduce:
1. Create a public project and set issues as `Only Project Members`
2. As a different user (non member), you wont see issues tab
3. Now visit `https://gitlab.com/<Group>/<project>/autocomplete_sources/milestones` in browser and it will list all the milestones of the project!
Regards,
Ashish
## Impact
See all the milestones of the public projects when issues are set as `Only Project Members`
## Links
Security issue: https://dev.gitlab.org/gitlab/gitlabhq/issues/279411.9Felipe ArturFelipe Artur2019-02-23https://gitlab.com/gitlab-org/gitlab-foss/-/issues/53861Allow to promote milestone from the API2019-03-12T13:52:43ZFelipe ArturAllow to promote milestone from the APIThere is a feature to promote project milestone to a group milestone on GitLab UI which is missing from the API.
There should be an endpoint to do the same from the API.There is a feature to promote project milestone to a group milestone on GitLab UI which is missing from the API.
There should be an endpoint to do the same from the API.11.9Nermin VehabovicNermin Vehabovichttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/52524Disclosure of attributes of Confidential Issues and Issue Weight in Milestone...2019-08-07T08:19:42ZGitLab SecurityBotDisclosure of attributes of Confidential Issues and Issue Weight in Milestones Page**[HackerOne report #420566](https://hackerone.com/reports/420566)** by ngalog on 2018-10-08:
Description:
Visit https://gitlab.com/golduserngalog/dfgsgfdg/milestones/1 and you will notice even the right panel show 0 open issues, howeve...**[HackerOne report #420566](https://hackerone.com/reports/420566)** by ngalog on 2018-10-08:
Description:
Visit https://gitlab.com/golduserngalog/dfgsgfdg/milestones/1 and you will notice even the right panel show 0 open issues, however in the burn down chart it shows one open issue, which is a confidential issue in the project `golduserngalog/dfgsgfdg`
Also, if you change the tab to issue weight in burndown chart, it will show 2 open issue weight, which is exactly the weight of the confidential issue.
Lastly, when you visit the bottom part of the milestone, you will notice the number of participant is 1, and he is golduserngalog, and the number of label is 1, and the label is security
## Impact
Leak the details of confidential issue in milestone page, details leaked include:
Label of confidential issue
Number of open confidential issue
Participants of confidential issue
Issue weight of confidential issue
## Attachments
**Warning:** Attachments received through HackerOne, please exercise caution!
* [Screen_Shot_2018-10-08_at_10.38.30_PM.png](https://h1-attachments-test.s3.us-east-1.amazonaws.com/420566/357126/Screen_Shot_2018-10-08_at_10.38.30_PM.png)
* [Screen_Shot_2018-10-08_at_10.38.16_PM.png](https://h1-attachments-test.s3.us-east-1.amazonaws.com/420566/357125/Screen_Shot_2018-10-08_at_10.38.16_PM.png)11.9Jarka Košanovájarka@gitlab.comJarka Košanovájarka@gitlab.com2019-01-23https://gitlab.com/gitlab-org/gitlab-foss/-/issues/51971IDOR Get milestone names of any private projects of Gitlabs2019-08-07T08:19:53ZJames RitcheyIDOR Get milestone names of any private projects of Gitlabs```
Link: https://hackerone.com/reports/412755
By: @ashish_r_padelkar
```
Details:
**Summary:**
Hello,
It is possible to get `Milestone` names of all the GITLAB private projects
**Description:**
When you create...```
Link: https://hackerone.com/reports/412755
By: @ashish_r_padelkar
```
Details:
**Summary:**
Hello,
It is possible to get `Milestone` names of all the GITLAB private projects
**Description:**
When you create any issue for milestones, the following url is used
`https://gitlab.com/ashishprsspl444/OutsideProjectOther/issues/new?issue%5Bmilestone_id%5D=655554`
As you can see, there is parameter `issue%5Bmilestone_id%5D` in the request which is the milestone ID. If you replace this ID with any sequential ID, you should see milestones which may be belong to private projects or groups!
#Steps
1. Just visit the url `https://gitlab.com/<userName>/<Project>/issues/new?issue%5Bmilestone_id%5D=<ProjectID>`
2. You should see name of the milestone populated in `Milestones` dropdown
3. This way you can enumerate all the milestones of GITLAB companies!!
Regards,
Ashish
## Impact
Get milestone names of all the users from GITLAB11.9Jarka Košanovájarka@gitlab.comJarka Košanovájarka@gitlab.com2019-01-23https://gitlab.com/gitlab-org/gitlab-foss/-/issues/59296Get milestone by title via API2019-03-27T09:01:15ZFabio BusattoGet milestone by title via API### Problem to solve
There are a bunch of APIs that require a `milestone_id` to be specified to set the value, for example https://docs.gitlab.com/ee/api/merge_requests.html#create-mr.
```
milestone_id | The global ID of a milestone
``...### Problem to solve
There are a bunch of APIs that require a `milestone_id` to be specified to set the value, for example https://docs.gitlab.com/ee/api/merge_requests.html#create-mr.
```
milestone_id | The global ID of a milestone
```
The only way to get the id is to list all the milestones for a given project (or group), and then select the one with the correct `title` attribute. Even with `search`, we cannot be sure we'll get only the result we need.
It would be easier to directly select a milestone by title, in a similar way we can select users by username:
```
GET /users?username=:username
```
### Proposal
Improve current API calls to allow selecting a specific milestone by title
```
GET /projects/:id/milestones?title=:title
GET /groups/:id/milestones?title=:title
```11.10Fabio BusattoFabio Busattohttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/49910Reopening a closed milestone from the Closed Milestones page fails2019-08-07T08:21:04ZHarish RamachandranReopening a closed milestone from the Closed Milestones page failsZD: https://gitlab.zendesk.com/agent/tickets/101358
Clicking **Reopen Milestone** on the _Closed_ Milestones page throws a `HTTP ERROR 400` error. From a personal instance, here's the error in the logs:
```
2018-08-02T20:43:41.3407867...ZD: https://gitlab.zendesk.com/agent/tickets/101358
Clicking **Reopen Milestone** on the _Closed_ Milestones page throws a `HTTP ERROR 400` error. From a personal instance, here's the error in the logs:
```
2018-08-02T20:43:41.340786761Z ==> /var/log/gitlab/gitlab-rails/production.log <==
2018-08-02T20:43:41.340791356Z
2018-08-02T20:43:41.340794561Z ActionController::ParameterMissing (param is missing or the value is empty: milestone):
2018-08-02T20:43:41.340797173Z app/controllers/projects/milestones_controller.rb:130:in `milestone_params'
2018-08-02T20:43:41.340799656Z app/controllers/projects/milestones_controller.rb:63:in `update'
2018-08-02T20:43:41.340802570Z lib/gitlab/i18n.rb:51:in `with_locale'
2018-08-02T20:43:41.340805902Z lib/gitlab/i18n.rb:57:in `with_user_locale'
2018-08-02T20:43:41.340808325Z app/controllers/application_controller.rb:370:in `set_locale'
2018-08-02T20:43:41.340810802Z lib/gitlab/middleware/multipart.rb:97:in `call'
2018-08-02T20:43:41.340813232Z lib/gitlab/request_profiler/middleware.rb:14:in `call'
2018-08-02T20:43:41.340815672Z ee/lib/gitlab/jira/middleware.rb:15:in `call'
2018-08-02T20:43:41.340818635Z lib/gitlab/middleware/go.rb:17:in `call'
2018-08-02T20:43:41.340821052Z lib/gitlab/etag_caching/middleware.rb:11:in `call'
2018-08-02T20:43:41.340823608Z lib/gitlab/middleware/read_only/controller.rb:38:in `call'
2018-08-02T20:43:41.340826729Z lib/gitlab/middleware/read_only.rb:16:in `call'
2018-08-02T20:43:41.340829145Z lib/gitlab/request_context.rb:18:in `call'
2018-08-02T20:43:41.340831515Z lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
2018-08-02T20:43:41.340833997Z lib/gitlab/middleware/release_env.rb:10:in `call'
```
My personal instance was running 11.1.4-ee.
Example url on gitlab.com: https://gitlab.com/harish_test_group/push-rules/milestones?sort=due_date_desc&state=closed
Click **Reopen Milestone** to see the error.11.10Mark FletcherMark Fletcherhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/62114Ampersand in Milestone Label isn't escaped properly in slash commands2019-08-07T08:15:55ZJohn Northrupjohn@8bitwizard.netAmpersand in Milestone Label isn't escaped properly in slash commands### Summary
When using the `/milestone` command in a comment to assign a milestone to an issue, when the milestone has an ampersand in the name the command is not processed properly. The modal displays that the command was run, however ...### Summary
When using the `/milestone` command in a comment to assign a milestone to an issue, when the milestone has an ampersand in the name the command is not processed properly. The modal displays that the command was run, however no milestone tag is ever set.
### Steps to reproduce
Generate a milestone with an ampersand in the name and try and set it on an issue via the slash commands.
### Example Project
https://gitlab.com/groups/gitlab-com/gl-infra/-/issues
### What is the current *bug* behavior?
Nothing happens upon execution and display that your command has processed.
### What is the expected *correct* behavior?
That the selected Milestone tag be added to the issue.12.0Sean McGivernSean McGivernhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/58060Project milestones with the same name within a group2019-05-27T12:46:00ZJorge Aguilar-Tablada TrenadoProject milestones with the same name within a group### Summary
Two project milestones with the same name within a group. From the milestones view of the group, it shows that there are two open but only one of them appears.
### Steps to reproduce
- Create a group with two project...### Summary
Two project milestones with the same name within a group. From the milestones view of the group, it shows that there are two open but only one of them appears.
### Steps to reproduce
- Create a group with two projects
- Create a milestone in each project with the same name
- Access the view of group milestones
### Example Project
[Group milestones view](https://gitlab.com/groups/curso_ib_maagtrjo/-/milestones)
[1st project milestone view](https://gitlab.com/curso_ib_maagtrjo/ib_forks/milestones)
[2nd project milestone view](https://gitlab.com/curso_ib_maagtrjo/ejercicio_1/milestones)
### What is the current *bug* behavior?
Although the counter shows 2 milestones open, I only see one of them in the list, so I can only access one from the dashboard.
Also in a previous test when I have promoted only the milestone of one of the projects, the result was that both have been promoted at the same time and consequently merged.
### What is the expected *correct* behavior?
To be able to see the two milestones from the project milestones dashboard although they have the same name since they correspond to different projects.
When both milestones will be promoted separately to the group then merge them and have only a single milestone group.
### Relevant logs and/or screenshots
- n/a
### Output of checks
This bug happens on GitLab.com12.0https://gitlab.com/gitlab-org/gitlab-foss/-/issues/64321Wrong URL when creating milestones from instance milestones dashboard2019-07-10T13:18:22ZDeAndre HarrisWrong URL when creating milestones from instance milestones dashboard<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label.
For the Community Edition issue tracker:
- https://gitlab.com/gitlab-org/gitlab-ce/issues?...<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label.
For the Community Edition issue tracker:
- https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name%5B%5D=bug
For the Enterprise Edition issue tracker:
- https://gitlab.com/gitlab-org/gitlab-ee/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab-ee/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
It is not possible to create a group milestone from the instance milestones dashboard. The URL is incorrect, leading to a 404. It works, however, for creating milestones in projects.
### Steps to reproduce
1. Go to `Milestones` (https://gitlab.com/dashboard/milestones?nav_source=navbar)
2. Search for a group from the dropdown, select it, and click `New milestone in <group>`
3. The URL is incorrect (navigates to `https://gitlab.com/groups/<group>/milestones/new`, should be `https://gitlab.com/groups/<group>/-/milestones/new`
### Example Project
https://gitlab.com/groups/gitlab-gold
### What is the current *bug* behavior?
Wrong URL: `https://gitlab.com/groups/<group>/milestones/new`
### What is the expected *correct* behavior?
Right URL: `https://gitlab.com/groups/<group>/-/milestones/new`
### Relevant logs and/or screenshots
![](http://gitlab.deandre.wtf/WK0cNx+)
### Output of checks
This bug happens on GitLab.com
### Workaround
Use the group-level milestones dashboard
### Related support tickets (internal)
- https://gitlab.zendesk.com/agent/tickets/12606212.1Dmytro Zaporozhets (DZ)Dmytro Zaporozhets (DZ)