1. 16 Aug, 2017 1 commit
  2. 31 May, 2017 1 commit
  3. 17 May, 2017 1 commit
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
      ac382b56
  4. 21 Apr, 2017 1 commit
  5. 20 Apr, 2017 1 commit
  6. 14 Mar, 2017 1 commit
  7. 23 Feb, 2017 1 commit
  8. 21 Feb, 2017 1 commit
  9. 20 Feb, 2017 1 commit
  10. 16 Feb, 2017 1 commit
  11. 15 Feb, 2017 1 commit
  12. 14 Feb, 2017 1 commit
  13. 26 Jan, 2017 1 commit
  14. 03 Jan, 2017 1 commit
  15. 14 Dec, 2016 1 commit
  16. 13 Dec, 2016 2 commits
  17. 01 Dec, 2016 1 commit
  18. 28 Nov, 2016 1 commit
  19. 24 Oct, 2016 1 commit
  20. 11 Oct, 2016 1 commit
  21. 05 Oct, 2016 1 commit
    • Marc Siegfriedt's avatar
      multi-file commit · a1ee8cf5
      Marc Siegfriedt authored
      add docs and tests - add additional validation
      allow move without content
      updated response
      a1ee8cf5
  22. 18 Sep, 2016 1 commit
  23. 13 Sep, 2016 1 commit
  24. 12 Sep, 2016 1 commit
  25. 15 Aug, 2016 1 commit
  26. 11 Aug, 2016 2 commits
    • Kamil Trzciński's avatar
      Pre-create all builds for Pipeline when a trigger is received · 39203f1a
      Kamil Trzciński authored
      This change simplifies a Pipeline processing by introducing a special new status: created.
      This status is used for all builds that are created for a pipeline.
      We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped).
      This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled.
      This also allows us to visualise a full pipeline (with created builds).
      
      This also removes an after_touch used for updating a pipeline state parameters.
      Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
      39203f1a
    • Lin Jen-Shin's avatar
  27. 09 Aug, 2016 1 commit
  28. 03 Aug, 2016 1 commit
  29. 28 Jul, 2016 1 commit
  30. 27 Jun, 2016 1 commit
  31. 03 Jun, 2016 2 commits
  32. 29 Apr, 2016 1 commit
  33. 17 Apr, 2016 1 commit
  34. 11 Apr, 2016 1 commit
  35. 06 Mar, 2016 1 commit
  36. 12 Oct, 2015 1 commit
  37. 08 May, 2015 1 commit
    • Martin Luder's avatar
      Order commit comments in API chronologically · 55f91f3d
      Martin Luder authored
      When fetching commit comments via API, the comments were not ordered,
      but just returned in the order Postgresql finds them. Now the API always
      returns comments in chronological order.
      55f91f3d