Disable observers in specs. Enable only when observer is under test.
Used the built-in observer enable/disable feature in ActiveModel. ActiveRecord::Base includes ActiveModel::Observing which provides this behavior. Simple wraps to enable the observer under test were added to the specs for: ActivityObserver, IssueObserver, Admin::Users and Issues. The spec for Project.last_activity was refactored to separate the tests for #last_activity and #last_activity_date. Each had doubles added to isolate the spec from the hidden dependency on the ActivityObserver action to create an Event for the project when an Issue is created. This ActivityObserver behavior is already tested by its spec.  http://api.rubyonrails.org/classes/ActiveModel/ObserverArray.html
Showing with 62 additions and 30 deletions