Commit dbbd7212 authored by Simon Knox's avatar Simon Knox

fix Settings spec -> use hidden class instead of hide

also remove debug
parent 80766821
Pipeline #21041105 failed with stages
in 46 minutes and 55 seconds
......@@ -2,7 +2,7 @@
.row
.col-lg-12.js-ci-variable-list-section{ data: { save_endpoint: save_endpoint } }
.hide.alert.alert-danger.js-ci-variable-error-box
.hidden.alert.alert-danger.js-ci-variable-error-box
  • This was originally .hide. I thought removing .hide in the bootstrap4 upgrade was a small feat but since jQuery uses that in .show(), .hide() and .toggle() and the fact that .hidden sets !important. I think it might be better to leave .hide in our codebase. I was reverting it and realized I forgot to change the JS counterpart.

    Not removing .hide may also decrease the number of file changes, which is nice 😄

Please register or sign in to reply
%ul.ci-variable-list
- @variables.each.each do |variable|
......
......@@ -10,8 +10,6 @@ feature 'Multi-file editor new directory', :js do
visit project_tree_path(project, :master)
live_debug
wait_for_requests
click_link('Web IDE')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment