Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
GitLab Community Edition
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Locked Files
Issues
13,964
Issues
13,964
List
Boards
Labels
Service Desk
Milestones
Merge Requests
802
Merge Requests
802
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
GitLab.org
GitLab Community Edition
Commits
c648756a
Unverified
Commit
c648756a
authored
Aug 17, 2016
by
Connor Shea
🏄
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix more incomplete if/else statements.
parent
d8654744
Pipeline
#3970406
canceled with stages
in 40 minutes and 33 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
0 deletions
+8
-0
jump_to_discussion.js.es6
...vascripts/diff_notes/components/jump_to_discussion.js.es6
+2
-0
resolve_discussion_btn.js.es6
...ripts/diff_notes/components/resolve_discussion_btn.js.es6
+6
-0
No files found.
app/assets/javascripts/diff_notes/components/jump_to_discussion.js.es6
View file @
c648756a
...
...
@@ -16,6 +16,8 @@
allResolved: function () {
if (this.discussion) {
return this.unresolvedDiscussionCount === 0;
} else {
return true;
}
},
showButton: function () {
...
...
app/assets/javascripts/diff_notes/components/resolve_discussion_btn.js.es6
View file @
c648756a
...
...
@@ -22,11 +22,15 @@
showButton: function () {
if (this.discussion) {
return this.discussion.isResolvable();
} else {
return undefined;
}
},
allResolved: function () {
if (this.discussion) {
return this.discussion.isResolved();
} else {
return undefined;
}
},
buttonText: function () {
...
...
@@ -39,6 +43,8 @@
loading: function () {
if (this.discussion) {
return this.discussion.loading;
} else {
return undefined;
}
}
},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment