Commit 3c25ec88 authored by Dylan Griffith's avatar Dylan Griffith

Fix Auto DevOps missing domain error handling

For some reason this value can be an empty string and we want to ensure
that we correctly fail the job before a deploy. This is particularly
problematic at the moment when coupled with
gitlab-org/gitlab-ce#54760 as the user has no
easy way to recover without destroying the cluster and starting over.
parent 5a2be4c8
Pipeline #53974514 (#954132) passed with stages
in 82 minutes and 8 seconds
---
title: Fix Auto DevOps missing domain error handling
merge_request: 26627
author:
type: fixed
......@@ -856,7 +856,7 @@ rollout 100%:
function check_kube_domain() {
ensure_kube_ingress_base_domain
if [ -z ${KUBE_INGRESS_BASE_DOMAIN+x} ]; then
if [[ -z "$KUBE_INGRESS_BASE_DOMAIN" ]]; then
echo "In order to deploy or use Review Apps,"
echo "AUTO_DEVOPS_DOMAIN or KUBE_INGRESS_BASE_DOMAIN variables must be set"
echo "From 11.8, you can set KUBE_INGRESS_BASE_DOMAIN in cluster settings"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment