• Yorick Peterse's avatar
    Eager load event target authors whenever possible · dac51ace
    Yorick Peterse authored
    This ensures that the "author" association of an event's "target"
    association is eager loaded whenever the "target" association defines an
    "author" association. This in turn solves the N+1 query problem we first
    tried to solve in
    gitlab-org/gitlab-ce!15788 but caused
    problems when displaying milestones as those don't define an "author"
    association.
    
    The approach in this commit does mean that the authors are _always_
    eager loaded since this takes place in the "belongs_to" block. This
    however shouldn't pose too much of a problem, and as far as I can tell
    there's no real way around this unfortunately.
    dac51ace
conditionally-eager-load-event-target-authors.yml 102 Bytes