External issue tracker integration broken in 9.5.0

Summary

When configuring an external issue tracker like Redmine, Jira, Bugzilla the integration is not working anymore. Verified with Redmine and Bugzilla. Both on a private gitlab instance (CE) and gitlab.com

Steps to reproduce

  1. Go to Project->Settings->Integrations->Redmine
  2. Fill & save the form. e.g
Project URL: https://redmine.example.com/projects/someproject
Issues URL: https://redmine.example.com/issues/:id
New issues URL https://redmine.example.com/projects/someproject/issues/new
  1. Click on "Issues" in navigation

Example Project

https://gitlab.com/jbbr/testproject - configured with Redmine

What is the current bug behavior?

  • Gitlab issue tracker is still used everywhere (Issues can be created, list/board/labels... is visible)
  • References of issues in commit messages are not referencing the external tracker

What is the expected correct behavior?

  • Gitlab Issues Button references the external issues page configured in the integration
  • References of issues link directly to the external tracker

Output of checks

This bug happens on GitLab.com but also hosted CE.

Results of GitLab environment info

Expand for output related to GitLab environment info

$ sudo gitlab-rake gitlab:env:info

System information System: Ubuntu 14.04 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 12.0.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknown

GitLab information Version: 9.5.0 Revision: 77bfdac Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.example.com HTTP Clone URL: https://gitlab.example.com/some-group/some-project.git SSH Clone URL: git@gitlab.example.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: google_oauth2

GitLab Shell Version: 5.8.0 Repository storage paths:

  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

$ sudo gitlab-rake gitlab:check SANITIZE=true Checking GitLab Shell ...

GitLab Shell version >= 5.8.0 ? ... OK (5.8.0) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 5/1 ... ok 5/2 ... repository is empty 7/3 ... ok 7/4 ... ok 9/6 ... ok 5/7 ... ok 5/8 ... ok 12/9 ... ok 13/10 ... ok 16/12 ... ok 17/13 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 5/1 ... yes 5/2 ... yes 7/3 ... yes 7/4 ... yes 9/6 ... yes 5/7 ... yes 5/8 ... yes 12/9 ... yes 13/10 ... yes 16/12 ... yes 17/13 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.3) Git version >= 2.7.3 ? ... yes (2.13.5) Active users: ... 8

Checking GitLab ... Finished