• Andrew Newdigate's avatar
    Bring back a custom dialler for Gitaly Ruby · 6e8b4bcb
    Andrew Newdigate authored
    This is a second fix for the GRPC bug related to using unix sockets
    alongside unix sockets. Previously we fixed incoming clients. This
    change fixes the connection between Gitaly and Gitaly-Ruby, which
    always relies on unix sockets, and which currently fail when http
    proxies are setup.
    
    A (too) long history of this change:
    
    * Unix sockets have never been officially supported by gRPC
    * Originally unix sockets didn't work at all, and you had to use a
      dialer
    * Attempted to upgrade from gRPC 1.9 to 1.16 and found that our dialer
      broke connectivity:
      !972
    * Isolated the problem to this commit:
      https://github.com/grpc/grpc-go/commit/90dca43332f6cc944c37e16f32a82c41639e7705
    * Fixed the problem by switching to the default dialer for unix: URLs
    * (note that it's still not officially supported, but without
      integration tests with proxy configurations, it seems to work)
    * In #1447, discovered that the default dialer breaks if one has http
      proxies configured (there was a also a second failure in
      !1032 which
      involved clients talking to Gitaly)
    * This change partially reverts
      !972 while keeping
      the fix for the original connectivity issue
    6e8b4bcb
Name
Last commit
Last update
..
testdata Loading commit data...
address_parser.go Loading commit data...
address_parser_test.go Loading commit data...
dial.go Loading commit data...
dial_test.go Loading commit data...
pool.go Loading commit data...
pool_darwin.go Loading commit data...
receive_pack.go Loading commit data...
std_stream.go Loading commit data...
upload_archive.go Loading commit data...
upload_pack.go Loading commit data...