Conversation OperationService::UserCherryPick

Stages:

RPC Design: #738 (closed)
~"Client Implementation": #737 (closed)
Server Implementation: #736 (closed)
~"Acceptance Testing": #845 (closed)

RPC Endpoints:

OperationService::UserCherryPick

Known Client Routes:

Browse to commit show page
click 'Options'
choose 'Cherry Pick'

Test cases should include a successful request where start_repository == repository and where start_repository != repository.

Use a Gitaly test server with authentication. Gitaly-ruby will act as a gRPC client and we want to be sure it is authenticating correctly. You probably want to use an external test package, see https://gitlab.com/gitlab-org/gitaly/blob/557cc726bd932d54f4d1340e52b81e4cf155cb48/internal/service/repository/fetch_test.go#L1.

The GitalyRemoteRepository class is currently missing a branch_exists? method. You will have to add it.

Inside gitaly-ruby, 'repository' will be a Gitlab::Git::Repository instance. But 'start_repository' will be a Gitlab::Git::GitalyRemoteRepository instance.

Edited Dec 20, 2017 by Ahmad Sherif

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information