Skip to content

n + 1 issue in CommitService::GetTreeEntries

~Conversation #320 (closed)


From #428 (comment 39113757)

I'm seeing spikes up to 250 calls a second on this interface at the moment.

image

https://performance.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GetTreeEntries&var-job=gitaly-production&refresh=1m&panelId=1&fullscreen

Is there an n + 1 problem that we need to be addressing?


Looks like it is an n+1...

Pick a repository and look at the number of calls:

image https://log.gitlap.com/goto/4931ecb05fa50f6063f2fb97b9988f43

No activity, then 150 calls in a few seconds - all for the same repository, followed by nothing...

Edited by Andrew Newdigate
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information