Acceptance Testing: CommitService::CommitsByMessage
~Conversation: #384 (closed)
See the Migration Process documentation for more information on the Acceptance Testing stage of the process.
Feature Toggle Name: gitaly_xxxxx
1. Preparation
-
Routes: what routes use this migration? - Please list a set of routes that are known to use this endpoint
-
Sentry: -
Ensure that all gitaly_migrate
issues in theGitLab.com
tracker are either assigned or resolved: https://sentry.gitlap.com/gitlab/gitlabcom/?query=is%3Aunresolved+is%3Aunassigned+gitaly_migrate -
Ensure that all issues in the Gitaly Production
tracker are either assigned or resolved: https://sentry.gitlap.com/gitlab/gitaly-production/?query=is%3Aunresolved+is%3Aunassigned
-
-
Grafana -
Link to the Gitaly Feature Status dashboard (edit accordingly): https://performance.gitlab.net/dashboard/db/gitaly-feature-status?var-method=CommitStats&refresh=5m&orgId=1
-
-
Kibana -
Based on routes listed above, provide a Kibana short-url link to incoming requests to that route. Use this example (for /:group/:project/commits
) as a template: https://log.gitlap.com/goto/e789c1efc8bafaba6a4a4289093529a8 -
Provide a Kibana short-url link to Gitaly logs related to this endpoint
-
2. Development and Staging Trial
- Enable on
dev.gitlab.org
:- ssh into
dev.gitlab.org
and enable the feature running by runningFeature.get('gitaly_FEATURE_NAME').enable
on a rails console. - Perform some testing and leave the feature enabled
- ssh into
- Enable on
staging.gitlab.com
in#development
- Perform some testing and leave the feature enabled
2. Low Impact Trial
- Set Gitaly to 5% using the command
!feature-set gitaly_FEATURE_NAME 5
in#production
- Leave running for at least 2 hours
- Monitor sentry, grafana and kibaba links above, every 30 minutes
- On usual activity, disable trial with
!feature-set gitaly_FEATURE_NAME false
in#production
- On usual activity, disable trial with
2. Mid Impact Trial
- Set Gitaly to 50% using the command
!feature-set gitaly_FEATURE_NAME 50
in#production
- Leave running for at least 24 hours
- Monitor sentry, grafana and kibaba links above, every few hours
- On usual activity, disable trial with
!feature-set gitaly_FEATURE_NAME false
in#production
- On usual activity, disable trial with
2. Full Impact Trial
- Set Gitaly to 100% using the command
!feature-set gitaly_FEATURE_NAME 50
in#production
- Leave running for at least a week
- Monitor sentry, grafana and kibaba links above daily
- On usual activity, disable trial with
!feature-set gitaly_FEATURE_NAME false
in#production
- On usual activity, disable trial with
3. Outcome
-
Report on the outcome of the tests (leave comments on this issue)
-
Did the migration perform as expected? -
Did the code have reasonable performance characteristics? -
Did error rates jump to an unacceptable level?
-
-
Additional Runbook information required? -
If so, was it added? (link to MR)
-
-
Prometheus Alerts Added -
If so, was it added? (link to MR)
-