Conversation CommitService::FindAllCommits

Gitlab::Git::Commit.find_all

---

• RPC Design: #374 (closed)

• Server Implementation: #375 (closed)

• ~"Client Implementation": #396 (closed) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12476 https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2269 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12934

• ~"Acceptance Testing": #518 (closed)

• Issues:

---

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/git/commit.rb

Preparatory clean-up is being done in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12476

service CommitService {
  // Use a stream to paginate the result set
  rpc FindAllCommits(FindAllCommitsRequest) returns (stream FindAllCommitsResponse) {};
}

message FindAllCommitsRequest {
  Repository repository = 1;
  bytes revision = 2; // When nil, return all commits reachable by any branch in the repo
  int32 max_count = 3;
  int32 skip = 4;
  enum Order {
    NONE = 0;
    TOPO = 1;
    DATE = 2;
  }
  Order order = 5;
}

// A single 'page' of the result set
message FindAllCommitsResponse {
  repeated GitCommit commits;
}

It seems this functionality is only used by https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/network/graph.rb .

The implementation can use git log (see comments below).