Conversation CommitService::FindCommit

Gitlab::Git::Commit.find

---

Stages:

• RPC Design: #362 (closed) gitaly-proto!37 (merged)

• Server Implementation: #373 (closed) !217 (merged)

• ~"Client Implementation": #402 (closed) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13094

• ~"Acceptance Testing": #514 (closed)

Issues:

• #605 (closed) (investigate severity)
• https://gitlab.com/gitlab-org/gitlab-ce/issues/38308#note_41326452

Blocked On:

• Resolution of at least some of the n+1 issues associated with this endpoint: #514 (comment 45075844)
  • #1055 (closed)
  • #1056 (closed)
  • #1057 (closed)
• One or more of:
  • https://gitlab.com/gitlab-org/gitlab-ce/issues/38632
  • https://gitlab.com/gitlab-org/gitlab-ce/issues/37772 (possibly a duplicate of https://gitlab.com/gitlab-org/gitlab-ce/issues/38632)
  • https://gitlab.com/gitlab-org/gitlab-ee/issues/3593

RPC Endpoints:

• Endpoint::Name

Known Client Routes:

• Known client endpoints

---

https://gitlab.com/gitlab-org/gitlab-ce/blob/40cd50829944db38fac07014e5fa00eafa3d1bc7/lib/gitlab/git/commit.rb#L51-66

This one needs to be coordinated with, or done after #315 (closed) because both depend on having an RPC message embedded in the response that can be turned into a Gitlab::Git::Commit instance.