Follow-up from "Add Praefect summary for how much latency praefect adds to gitaly calls"
The following discussion from !1655 (closed) should be addressed:
-
@pokstad1 started a discussion: (+6 comments) @johncai Could you please link the related issue so I can find the background information? The motivation and problem you're trying to solve isn't clear to me.
My first impression is that we should break this up into smaller pieces since some of this is more straight forward than other pieces:
- Praefect prometheus setup code
- gRPC proxy metrics (a way to track performance of just the proxy including the Gitaly routed RPC)
I'm not sure about the time injecting piece. Don't we already track the amount of time each Gitaly RPC takes?
We could just log the amount of time Praefect takes for each request, along with the correlation ID, and compare this against the (existing?) Gitaly log containing the request duration. We already track Gitaly RPC durations in Kibana, so I think we have some kind of middleware logging this already in LabKit.