Include the /vendor directory in the repository
A follow-up of sorts to #15 (closed).
We currently have the /vendor
in .gitignore. This forces everyone who installs gitaly to download all the dependencies (the equivalent of bundle install
in Ruby projects).
I think this is a bad idea. First of all, bundle install
is a horrible waste of time and bandwidth, and a source of failures, for everybody who has to build/install our software. This applies equally in the Go case. Second of all, the situation is worse for Go because unlike in the Ruby world you pull each package from its own web address. Each of these sources becomes a point of failure for the build.
By having the /vendor directory in source control we make the build process significantly more reliable and faster.
Opinions please! cc @marin