Send metadata to indicate whether a given RPC reused an existing cat-file process
I noticed in gitlab-com/www-gitlab-com!23143 (merged), the Ajax request for discussions.json
shows 1,164 Gitaly calls:
gitlab-com/www-gitlab-com!23143 (merged)
It looks like this is coming from Markdown rendering for RelativeLinkFilter#current_commit
, but I would have thought this would be mitigated by the cat-file cache:
In addition there are a lot of these calls as well:
Note that https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29951 solves this problem by reusing the same FindCommit
request, but I'm wondering whether the cat-file
cache is working. Can we somehow mark these requests as cached if it were cached?
Edited by Stan Hu