Add explicit integration tests for gitaly-ssh and GitalyRemoteRepository
Inside Gitaly we have two Gitaly clients:
-
gitaly-ssh
(used for inter-Gitaly Git replication) - GitalyRemoteRepository (used by gitaly-ruby to interact with repositories on other Gitaly servers)
Both of these are exercised indirectly by our RPC tests that rely on them. However, we do not have tests that explicitly test that these things can connect to a Gitaly server and "do their thing". This is becoming increasingly relevant because:
- we are transitioning between two authentication schemes
- we are in the process of adding TLS support to Gitaly, meaning there are three types of connection: Unix, TCP, TLS (encrypted TCP)
We need to add tests that focus on this matrix of connection options.