Remove obsolete 'exec git' code from gitlab-shell
I'm not sure if this belongs on the Gitaly issue tracker but here goes.
It used to be that gitlab-shell would run git-receive-pack
and git-upload-pack
during Git SSH sessions. This is no longer the case, gitlab-shell always uses Gitaly for this. (Speaking at time of GitLab 11.1.)
There is now a large chunk of technical debt in gitlab-shell around this stuff.
- special environment variables for git commands
- git tracing support
- a hard requirement to receive a "repository path" from gitlab's internal API
This is the sort of left-over stuff we're cleaning up in gitlab-ce as part of the Gitaly %v1.1 milestone. On those grounds I wonder if we should put this gitlab-shell cleanup into the v1.1 milestone too.