localrepo: Exercise `CloneBundle()` fsck configuration in test
Starting in Git version 2.46.0, executing git-clone(1) on a bundle
performs fsck checks when transfer.fsckObjects is enabled. Prior to
this, this configuration was always ignored and fsck checks were not
run. Unfortunately, fsck message severity configuration is ignored by
Git only for bundle clones.
This issue is resolved in Git version 2.48.0, but until this gets rolled
out to GitLab, disable transfer.fsckObjects so bundles containing fsck
errors can continue to be cloned. This matches behavior prior to Git
version 2.46.0.
Merge request reports
Activity
changed milestone to %17.9
added bugfunctional devopssystems groupgit sectioncore platform typebug labels
assigned to @justintobler
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None @mustafabayar(UTC+1, 7 hours ahead of author)
@echui-gitlab(UTC+11, 17 hours ahead of author)
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by ****
In 13ea55ce (localrepo: Disable
FetchBundle()fsck, 2024-10-10), a workaround to fix repository exports being blocked by failing fsck checks was implemented. This same approach is used to address repository imports. Once Git 2.48.0 gets rolled out these workarounds will no longer be necessary.@echui-gitlab @jamesliu-gitlab Would you mind reviewing?
requested review from @jamesliu-gitlab and @echui-gitlab
added 9 commits
-
b415c68d...0be46096 - 7 commits from branch
master - aa6493b5 - localrepo: Exercise `CloneBundle()` fsck configuration in test
- 2e2c9217 - localrepo: Disable `CloneBundle()` fsck
-
b415c68d...0be46096 - 7 commits from branch
started a merge train
mentioned in commit 6dc57705
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added devopsdata_access label and removed devopssystems label
