danger-review
Passed Started
by
@justintobler

Justin Tobler
1Running with gitlab-runner 16.3.0~beta.108.g2b6048b4 (2b6048b4)2 on blue-2.saas-linux-large-amd64.runners-manager.gitlab.com/default FFrYjQ9d, system ID: s_d4355a3578f53 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_FASTZIP:true, FF_USE_IMPROVED_URL_MASKING:true, FF_RESOLVE_FULL_TLS_CHAIN:false6Using Docker executor with image ruby:3.0 ...7Pulling docker image ruby:3.0 ...8Using docker image sha256:b280a4bf204e82f88d3a9497936456136359c166e66bc8369e4eb73a08898fd3 for ruby:3.0 with digest ruby@sha256:7770b25e2722aa6ac2efbc5d60219eba84939c0d37ca1811f45654a8a3ed77e8 ...10Running on runner-ffryjq9d-project-2009901-concurrent-0 via runner-ffryjq9d-s-l-l-amd64-1694461839-3d304855...12Fetching changes...13Initialized empty Git repository in /builds/gitlab-org/gitaly/.git/14Created fresh repository.15Checking out 8282a125 as detached HEAD (ref is refs/merge-requests/6339/train)...16Skipping Git submodules setup17$ git remote set-url origin "${CI_REPOSITORY_URL}"19Using docker image sha256:b280a4bf204e82f88d3a9497936456136359c166e66bc8369e4eb73a08898fd3 for ruby:3.0 with digest ruby@sha256:7770b25e2722aa6ac2efbc5d60219eba84939c0d37ca1811f45654a8a3ed77e8 ...20$ [[ ! -f "Gemfile" ]] && bundle init && bundle add gitlab-dangerfiles --version "$GITLAB_DANGERFILES_VERSION"21Writing new Gemfile to /builds/gitlab-org/gitaly/Gemfile22Fetching gem metadata from https://rubygems.org/..............23Resolving dependencies...24Fetching gem metadata from https://rubygems.org/...........25Fetching rake 13.0.626Installing rake 13.0.627Fetching public_suffix 5.0.328Using bundler 2.2.3329Fetching claide 1.1.030Fetching colored2 3.1.231Fetching nap 1.1.032Fetching open4 1.3.433Fetching ruby2_keywords 0.0.534Fetching faraday-net_http 3.0.235Fetching rchardet 1.8.036Installing colored2 3.1.237Installing faraday-net_http 3.0.238Installing ruby2_keywords 0.0.539Installing open4 1.3.440Installing claide 1.1.041Fetching rexml 3.2.642Fetching no_proxy_fix 0.1.243Fetching unicode-display_width 2.4.244Installing public_suffix 5.0.345Installing rchardet 1.8.046Installing nap 1.1.047Fetching mini_mime 1.1.548Fetching multi_xml 0.6.049Installing no_proxy_fix 0.1.250Installing unicode-display_width 2.4.251Installing rexml 3.2.652Installing multi_xml 0.6.053Fetching cork 0.3.054Fetching faraday 2.7.1055Installing mini_mime 1.1.556Fetching terminal-table 3.0.257Installing cork 0.3.058Installing faraday 2.7.1059Fetching claide-plugins 0.9.260Fetching httparty 0.21.061Installing terminal-table 3.0.262Fetching addressable 2.8.563Installing claide-plugins 0.9.264Installing httparty 0.21.065Installing addressable 2.8.566Fetching kramdown 2.4.067Fetching faraday-http-cache 2.5.068Fetching git 1.18.069Fetching sawyer 0.9.270Fetching gitlab 4.19.071Installing kramdown 2.4.072Installing faraday-http-cache 2.5.073Installing sawyer 0.9.274Installing git 1.18.075Installing gitlab 4.19.076Fetching octokit 6.1.177Installing octokit 6.1.178Fetching kramdown-parser-gfm 1.1.079Installing kramdown-parser-gfm 1.1.080Fetching danger 9.3.181Installing danger 9.3.182Fetching danger-gitlab 8.0.083Installing danger-gitlab 8.0.084Fetching gitlab-dangerfiles 3.1.085Installing gitlab-dangerfiles 3.1.086$ [[ ! -f "Gemfile.lock" ]] || bundle config set --local frozen "true"87$ bundle install88Using rake 13.0.689Using public_suffix 5.0.390Using addressable 2.8.591Using bundler 2.2.3392Using claide 1.1.093Using colored2 3.1.294Using cork 0.3.095Using nap 1.1.096Using open4 1.3.497Using claide-plugins 0.9.298Using faraday-net_http 3.0.299Using ruby2_keywords 0.0.5100Using faraday 2.7.10101Using faraday-http-cache 2.5.0102Using rchardet 1.8.0103Using git 1.18.0104Using rexml 3.2.6105Using kramdown 2.4.0106Using kramdown-parser-gfm 1.1.0107Using no_proxy_fix 0.1.2108Using sawyer 0.9.2109Using octokit 6.1.1110Using unicode-display_width 2.4.2111Using terminal-table 3.0.2112Using danger 9.3.1113Using mini_mime 1.1.5114Using multi_xml 0.6.0115Using httparty 0.21.0116Using gitlab 4.19.0117Using danger-gitlab 8.0.0118Using gitlab-dangerfiles 3.1.0119Bundle complete! 1 Gemfile dependency, 31 gems now installed.120Use `bundle info [gemname]` to see where a bundled gem is installed.121$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command122To use retry middleware with Faraday v2.0+, install `faraday-retry` gem123Results:124Markdown:125## Reviewer roulette126Changes that require review have been detected! A merge request is normally127reviewed by both a reviewer and a maintainer in its primary category and by a128maintainer in all other categories.129To spread load more evenly across eligible reviewers, Danger has picked a candidate for each130review slot. Feel free to131[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitaly)132if you think someone else would be better-suited133or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.134To read more on how to use the reviewer roulette, please take a look at the135[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)136and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).137Please consider assigning a reviewer or maintainer who is a138[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab-development-kit) in the area of the merge request.139Once you've decided who will review this merge request, mention them as you140normally would! Danger does not automatically notify them for you.141| Category | Reviewer | Maintainer |142| -------- | -------- | ---------- |143| ~ | [Toon Claes](https://gitlab.com/toon)  (`@toon`) (UTC+2, 6 hours ahead of `@wchandler`) | [Patrick Steinhardt](https://gitlab.com/pks-gitlab)  (`@pks-gitlab`) (UTC+2, 6 hours ahead of `@wchandler`) |144**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitaly/-/jobs/5061982959) that generated this comment.**146Job succeeded