Send back stdout/stderr output to FetchRemote call
Right now in Geo, if we call the Gitaly FetchRemote
service and git
fails to update, we get the exit code of 1 but don't have any way of logging the exact error. For example:
From http://primary.gitlap.com/root/rouge
! [rejected] master -> master (non-fast-forward)
This output would significantly help admins troubleshoot issues on the local repo in gitlab-org/gitlab-ee!3290. It doesn't look like this output is logged in grpc.log
, either. But perhaps we should log stdout if a non-zero exit code returned?
It looks to me we do have a stdout reader, which we should probably send back to the client in the FetchRemoteResponse
: