SSHReceivePack RPC is missing glProjectPath in log
This issue is raised from this slack thread. The grpc.request.glProjectPath
of SSHReceivePack
RPCs is missing in gitaly log.
How to reproduce
Use GDK to reproduce:
gdk tail gitaly | grep SSHReceivePack
- do a
git push
to any repo using ssh protocol - notice that gitaly logs from
SSHReceivePack
does not havegrpc.request.glProjectPath
Root cause analysis
It was introduced in this MR !6534 (diffs)
At this line !6534 (diffs), we declared
tags := grpcmwtags.NewTags()
every time we call injectTags
resulting any tags from previous call is missing.
Some background about !6534 (diffs). This commit a497cfc8 was introduced to remove github.com/grpc-ecosystem/go-grpc-middleware/tags
as a part of our effort to remove go-grpc-middleware v1
. But it is causing a defect #5694 (closed) and !6534 (merged) is to fix that defect.
Fix proposal
The tags
need to be remember and passed as a parameters of injectTags
funciton, which is basically reverting to the old logic before a497cfc8
Edited by Eric Ju