Missing repository metadata about UserCommitFiles
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author Developer
Something we've discussed during a sync meeting @pks-gitlab to investigate why we don't see this information at all for a single RPC.
- Maintainer
Looks like this isn't limited to
UserCommitFiles
.UserRebaseConfirmable
andFetchIntoObjectPool
are also affected. Collapse replies - Maintainer
I took a CSV export of that query, and it looks like even more RPCs are affected.
RPC Count CreateObjectPool 65 DeleteObjectPool 1 FetchIntoObjectPool 112 FindRemoteRepository 272 ListCommitsByOid 9 ResolveConflicts 2224 UpdateRemoteMirror 12 UserApplyPatch 9 UserCommitFiles 178850 UserRebaseConfirmable 11293 - Maintainer
There's some middleware that populates those fields. Maybe the affected RPCs aren't setting the object fields correctly.
- Maintainer
I think the issue lies here where we attempt to extract the
Repository
information.The affected RPCs, including UserCommitFiles and UserRebaseConfirmableRequest embed the
Repository
message within another message in the request. I think this causes the cast to fail, and therefore we never populate theRepository
information in the middleware. - Maintainer
I've started a draft MR that uses reflection to extract the
Repository
field. I'm unsure whether this is the right approach in terms of performance and safety. I'll try and add some benchmarks to check the performance impact.
- James Liu assigned to @jamesliu-gitlab
assigned to @jamesliu-gitlab
- James Liu added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- 🤖 GitLab Bot 🤖 added Category:Gitaly label
added Category:Gitaly label
- James Liu mentioned in merge request !6747 (merged)
mentioned in merge request !6747 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16813 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16813 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16919 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16919 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#16998 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16998 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17191 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17191 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17271 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17271 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %17.0
changed milestone to %17.0
- 🤖 GitLab Bot 🤖 added missed:16.11 label
added missed:16.11 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17347 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17347 (closed)
- James Liu added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- James Liu closed
closed
- James Liu added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label