Conversation RefService::FindBranch
Feature Flag: gitaly_find_branch
Stages:
-
~"Client Implementation": #502 (closed) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13873 -
~"Acceptance Testing": #571 (closed) #895 (closed)
Blocked On:
- Awaiting release of !405 (merged) into production
RPC Endpoints:
RefService::FindBranch
Known Issues:
- https://gitlab.com/gitlab-org/gitlab-ce/issues/38943 / https://sentry.gitlap.com/gitlab/devgitlaborg/issues/72184/
- #694 (closed) / https://sentry.gitlap.com/gitlab/gitaly-production/issues/107555/
Known Client Routes:
- Known client endpoints
We should use gitaly-ruby because this method relies on Rugged::BranchCollection which does weird things. E.g. master
, heads/master
and refs/heads/master
all return the same result.
service RefService {
rpc FindBranch(FindBranchRequest) returns (FindBranchResponse) {}
}
message FindBranchRequest {
Repository repository = 1;
// Name can be 'master' but also 'refs/heads/master'
bytes name = 2;
}
message FindBranchResponse {
Branch branch = 1;
}
// should go in shared.proto
message Branch {
bytes name = 1;
GitCommit target_commit = 2;
}
Edited by Ahmad Sherif