Translation of internal Gitaly errors into gRPC statuses
What
Enable the :convert_err_to_status
feature flag to reduce amount of Unknown
errors returned from the Gitaly.
More info in the #4587 (closed)
Owners
- Team: Gitaly
- Most appropriate slack channel to reach out to:
#g_gitaly
- Best individual to reach out to: @8bitlife
Expectations
What release does this feature occur in first?
15.6
What are we expecting to happen?
Reduced amount of Unknown
errors returned by the Gitaly RPCs.
What might happen if this goes wrong?
The wrong error codes might be returned.
What can we monitor to detect problems with this?
Significant changes in the status codes returned by any RPC when system operates without any issues.
Roll Out Steps
-
Enable on staging -
Is the required code deployed on staging? (howto) -
Enable on staging (howto) -
Add featureflagstaging to this issue (howto) -
Test on staging (howto) -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Enable on production -
Is the required code deployed on production? (howto) -
Enable on production in #production
(howto) -
Add featureflagproduction to this issue -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Default-enable the feature flag (optional, only required if backwards-compatibility concerns exist) -
Wait for release containg default-disabled feature flag. -
Change the feature flag to default-enabled (howto) -
Wait for release containing default-enabled feature flag.
-
-
Remove feature flag
Please refer to the documentation of feature flags for further information.
Edited by Pavlo Strokov