Flaky test TestProxyErrorPropagation/director_error_is_propagated
Job: https://gitlab.com/gitlab-org/gitaly/-/jobs/3251543669
=== FAIL: internal/praefect/grpc-proxy/proxy TestProxyErrorPropagation/request_finalizer_error_is_propagated (unknown)
panic: Fail in goroutine after TestProxyErrorPropagation/director_error_is_propagated has completed
goroutine 318 [running]:
testing.(*common).Fail(0xc0002f4680)
/usr/local/go/src/testing/testing.go:817 +0xe5
testing.(*common).Errorf(0xc0002f4680, {0xbe310d?, 0xc0002f4680?}, {0xc0000fdfb0?, 0x476b0f?, 0x11ad160?})
/usr/local/go/src/testing/testing.go:934 +0x65
github.com/stretchr/testify/assert.Fail({0x7f06d805c2e8, 0xc0002f4680}, {0xc000045080, 0x3c}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/assert/assertions.go:264 +0x384
github.com/stretchr/testify/assert.NoError({0x7f06d805c2e8, 0xc0002f4680}, {0xcf0bc0, 0xc0001116c0}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/assert/assertions.go:1392 +0x105
github.com/stretchr/testify/require.NoError({0xcf8420, 0xc0002f4680}, {0xcf0bc0, 0xc0001116c0}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/require/require.go:1261 +0x96
gitlab.com/gitlab-org/gitaly/v15/internal/testhelper.MustServe({0xcfe670, 0xc0002f4680}, {0xcf4620, 0xc0000001e0}, {0xcf9e00, 0xc0004655f0})
/builds/gitlab-org/gitaly/internal/testhelper/testhelper.go:122 +0xb6
created by gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/proxy_test.TestProxyErrorPropagation.func4
/builds/gitlab-org/gitaly/internal/praefect/grpc-proxy/proxy/handler_ext_test.go:347 +0x2c5
=== FAIL: internal/praefect/grpc-proxy/proxy TestFailDestinationWithError (unknown)
=== FAIL: internal/praefect/grpc-proxy/proxy TestHandler_carriesHeadersAndTrailers (unknown)
=== FAIL: internal/praefect/grpc-proxy/proxy TestHandler_directorErrorIsPropagated (unknown)
=== FAIL: internal/praefect/grpc-proxy/proxy TestProxyErrorPropagation (unknown)
panic: Fail in goroutine after TestProxyErrorPropagation/director_error_is_propagated has completed
goroutine 318 [running]:
testing.(*common).Fail(0xc0002f4680)
/usr/local/go/src/testing/testing.go:817 +0xe5
testing.(*common).Errorf(0xc0002f4680, {0xbe310d?, 0xc0002f4680?}, {0xc0000fdfb0?, 0x476b0f?, 0x11ad160?})
/usr/local/go/src/testing/testing.go:934 +0x65
github.com/stretchr/testify/assert.Fail({0x7f06d805c2e8, 0xc0002f4680}, {0xc000045080, 0x3c}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/assert/assertions.go:264 +0x384
github.com/stretchr/testify/assert.NoError({0x7f06d805c2e8, 0xc0002f4680}, {0xcf0bc0, 0xc0001116c0}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/assert/assertions.go:1392 +0x105
github.com/stretchr/testify/require.NoError({0xcf8420, 0xc0002f4680}, {0xcf0bc0, 0xc0001116c0}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/require/require.go:1261 +0x96
gitlab.com/gitlab-org/gitaly/v15/internal/testhelper.MustServe({0xcfe670, 0xc0002f4680}, {0xcf4620, 0xc0000001e0}, {0xcf9e00, 0xc0004655f0})
/builds/gitlab-org/gitaly/internal/testhelper/testhelper.go:122 +0xb6
created by gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/proxy_test.TestProxyErrorPropagation.func4
/builds/gitlab-org/gitaly/internal/praefect/grpc-proxy/proxy/handler_ext_test.go:347 +0x2c5
DONE 6240 tests, 11 failures in 435.597s
make: *** [Makefile:369: test-go] Error 1
section_end:1667219575:step_script
[0Ksection_start:1667219575:after_script
[0K[0K[36;1mRunning after_script[0;m[0;m
[32;1mRunning after script...[0;m
[32;1m$ # Checking for panics in ${TEST_FULL_OUTPUT} # collapsed multi-line command[0;m
[0Ksection_start:1667219576:panic_stack_traces[collapsed=true]
[0K[0;31mPanic stack traces[0m
panic: Fail in goroutine after TestProxyErrorPropagation/director_error_is_propagated has completed
goroutine 318 [running]:
testing.(*common).Fail(0xc0002f4680)
/usr/local/go/src/testing/testing.go:817 +0xe5
testing.(*common).Errorf(0xc0002f4680, {0xbe310d?, 0xc0002f4680?}, {0xc0000fdfb0?, 0x476b0f?, 0x11ad160?})
/usr/local/go/src/testing/testing.go:934 +0x65
github.com/stretchr/testify/assert.Fail({0x7f06d805c2e8, 0xc0002f4680}, {0xc000045080, 0x3c}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/assert/assertions.go:264 +0x384
github.com/stretchr/testify/assert.NoError({0x7f06d805c2e8, 0xc0002f4680}, {0xcf0bc0, 0xc0001116c0}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/assert/assertions.go:1392 +0x105
github.com/stretchr/testify/require.NoError({0xcf8420, 0xc0002f4680}, {0xcf0bc0, 0xc0001116c0}, {0x0, 0x0, 0x0})
/builds/gitlab-org/gitaly/.go/pkg/mod/github.com/stretchr/testify@v1.8.0/require/require.go:1261 +0x96
gitlab.com/gitlab-org/gitaly/v15/internal/testhelper.MustServe({0xcfe670, 0xc0002f4680}, {0xcf4620, 0xc0000001e0}, {0xcf9e00, 0xc0004655f0})
/builds/gitlab-org/gitaly/internal/testhelper/testhelper.go:122 +0xb6
created by gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/proxy_test.TestProxyErrorPropagation.func4
/builds/gitlab-org/gitaly/internal/praefect/grpc-proxy/proxy/handler_ext_test.go:347 +0x2c5
FAIL gitlab.com/gitlab-org/gitaly/v15/internal/praefect/grpc-proxy/proxy 0.055s