[Feature flag] Enable default core.autocrlf being set to false
What
Enable the :gitaly_autocrlf_false
feature flag which changes the default global configuration of core.autocrlf
from input
to false
. Gitaly should be agnostic to line endings #3476 (closed).
Changes are being made in !4836 (merged). When this flag is enabled Gitaly should no longer transforms line endings on commit.
Owners
- Team: Gitaly
- Most appropriate slack channel to reach out to:
#g_create_gitaly
- Best individual to reach out to: @justintobler
Expectations
What release does this feature occur in first?
16.5
What are we expecting to happen?
Gitaly becomes completely agnostic to line endings.
What might happen if this goes wrong?
What can we monitor to detect problems with this?
Roll Out Steps
-
Enable on staging -
Is the required code deployed on staging? (howto) -
Enable on staging (howto) -
Add featureflagstaging to this issue (howto) -
Test on staging (howto) -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Enable on production -
Is the required code deployed on production? (howto) -
Enable on production in #production
(howto) -
Add featureflagproduction to this issue -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Default-enable the feature flag (optional, only required if backwards-compatibility concerns exist) -
Wait for release containg default-disabled feature flag. -
Change the feature flag to default-enabled (howto) -
Wait for release containing default-enabled feature flag.
-
-
Remove feature flag
Please refer to the documentation of feature flags for further information.
Edited by Justin Tobler