User-aborted SSHUploadPackWithSidechannel invocations cause frequent alerts
Overview
The SSHUploadPackWithSidechannel function is not returning proper gRPC codes in almost all error cases. Most importantly, the case where a user seemingly aborts a fetch is not handled properly and will lead to an Internal
error. This is a very well-defined error case though that we ought to handle gracefully, e.g. by returning with Aborted
code.
We need to carefully consider how we can detect the case where a user has aborted the fetch. Most importantly, we should not return a graceful error code in case SSHUploadPack fails because of a network failure.
The error we get is:
fatal: the remote hung up unexpectedly
Incidents/Pages
Edited by Igor