[Feature flag] Enable use of structured errors in UserRebaseConfirmable
What
Enable the :gitaly_user_rebase_confirmable_improved_error_handling
feature flag, which enables the use of structured errors in UserRebaseConfirmable. With this feature enabled Gitaly starts to return errors in some cases where it previously returned successfully with an error embedded into the response.
Owners
- Team: Gitaly
- Most appropriate slack channel to reach out to:
#g_create_gitaly
- Best individual to reach out to: jcaigitlab
Expectations
What release does this feature occur in first?
What are we expecting to happen?
Gitaly should start to properly report errors in a subset of cases where it previously returned successfully.
What might happen if this goes wrong?
Reporting of errors in Rails may break.
What can we monitor to detect problems with this?
Roll Out Steps
-
Enable on staging -
Is the required code deployed on staging? (howto) -
Enable on staging (howto) -
Add featureflagstaging to this issue (howto) -
Test on staging (howto) -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Enable on production -
Is the required code deployed on production? (howto) -
Enable on production in #production
(howto) -
Add featureflagproduction to this issue -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Default-enable the feature flag (optional, only required if backwards-compatibility concerns exist) -
Wait for release containg default-disabled feature flag. -
Change the feature flag to default-enabled (howto) -
Wait for release containing default-enabled feature flag.
-
-
Remove feature flag
Please refer to the documentation of feature flags for further information.
Edited by John Cai