Make it mandatory to create a feature flag rollout issue before MRs are merged
While we typically create feature flag rollout issues, sometimes we forget to do this. This issue has surfaced in the context of &8287 (closed), where the rollout of gitaly_revlist_for_repo_size
is in an inconsistent state and where the rollout process is not documented anywhere.
We should make it mandatory to create a feature flag rollout issue before an MR is merged to avoid this situation. An easy mechanism would be to add a new parameter to featureflag.NewFeatureFlag()
that takes the URL of the feature flag rollout issue so that it becomes immediately obvious both during coding and during the review that something's missing. Furthermore, it provides a good back-link in case one is curious about the status of a feature flag.
Edited by Patrick Steinhardt