Migrate away from `[gitlab-shell]` configuration
Gitaly's configuration still has a [gitlab-shell]
section. This section is used for two things:
- As a fallback if
[gitlab] secret_file
isn't set to find the secret used to connect to the Rails API. We should just remove this fallback and always require[gitlab] secret_file
. - As a fallback if
[hooks] custom_hooks_dir
is not set to locate custom hooks. Again, we should just remove this fallback.
Ultimately it's confusing why Gitaly still refers to gitlab-shell
and we should stop doing that in our configuration. This requires a deprecation phase though.