Revert format of dial-nodes output to text
15199ee1 introduced a change to how the praefect dial-nodes
output is rendered.
Prior to this change we used log.Printf
15199ee1 so we got string output.
The change mentioned leads to the output being presented in JSON format.
This caused a number of E2E tests to fail in the pipeline, but also raises a concern that other users may have scripts that cannot handle the new JSON format. For maintaining backwards compatibility we should consider reverting to using the old style output.
// Old format
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: dialing...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: dialing...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: dialing...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: dialed successfully!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: checking health...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: dialed successfully!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: checking health...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: dialed successfully!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: checking health...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: SUCCESS: node is healthy!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: checking consistency...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: SUCCESS: node is healthy!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: checking consistency...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: SUCCESS: node is healthy!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: checking consistency...
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: SUCCESS: confirmed Gitaly storage "praefect-internal-0" in virtual storages [default] is served
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: SUCCESS: node configuration is consistent!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: SUCCESS: confirmed Gitaly storage "praefect-internal-1" in virtual storages [default] is served
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: SUCCESS: node configuration is consistent!
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: SUCCESS: confirmed Gitaly storage "praefect-internal-2" in virtual storages [default] is served
2021/11/11 16:40:17 [unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: SUCCESS: node configuration is consistent!
// New format
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: dialing...","pid":19056,"time":"2021-11-11T03:40:51.721Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: dialing...","pid":19056,"time":"2021-11-11T03:40:51.721Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: dialing...","pid":19056,"time":"2021-11-11T03:40:51.721Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: dialed successfully!","pid":19056,"time":"2021-11-11T03:40:51.722Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: checking health...","pid":19056,"time":"2021-11-11T03:40:51.722Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: dialed successfully!","pid":19056,"time":"2021-11-11T03:40:51.722Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: checking health...","pid":19056,"time":"2021-11-11T03:40:51.722Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: dialed successfully!","pid":19056,"time":"2021-11-11T03:40:51.722Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: checking health...","pid":19056,"time":"2021-11-11T03:40:51.722Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: SUCCESS: node is healthy!","pid":19056,"time":"2021-11-11T03:40:51.723Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: checking consistency...","pid":19056,"time":"2021-11-11T03:40:51.723Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: SUCCESS: node is healthy!","pid":19056,"time":"2021-11-11T03:40:51.723Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: SUCCESS: node is healthy!","pid":19056,"time":"2021-11-11T03:40:51.723Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: checking consistency...","pid":19056,"time":"2021-11-11T03:40:51.723Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: checking consistency...","pid":19056,"time":"2021-11-11T03:40:51.723Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: SUCCESS: confirmed Gitaly storage \"praefect-internal-0\" in virtual storages [default] is served","pid":19056,"time":"2021-11-11T03:40:51.741Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-0.socket]: SUCCESS: node configuration is consistent!","pid":19056,"time":"2021-11-11T03:40:51.741Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: SUCCESS: confirmed Gitaly storage \"praefect-internal-2\" in virtual storages [default] is served","pid":19056,"time":"2021-11-11T03:40:51.741Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-2.socket]: SUCCESS: node configuration is consistent!","pid":19056,"time":"2021-11-11T03:40:51.741Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: SUCCESS: confirmed Gitaly storage \"praefect-internal-1\" in virtual storages [default] is served","pid":19056,"time":"2021-11-11T03:40:51.742Z"}
{"level":"info","msg":"[unix:/Users/john/dev/gdk/gitaly-praefect-1.socket]: SUCCESS: node configuration is consistent!","pid":19056,"time":"2021-11-11T03:40:51.742Z"}