Misleading error message 'repo scoped: invalid Repository' when an invalid storage is passed to Praefect
When converting an existing instance over to Gitaly Cluster, mismatches between the rails storage name for the cluster and the virtual storage name configured in Praefect are common.
Currently Praefect returns error repo scoped: invalid Repository
to the client, which provides no clues to the nature of the problem.
This comment mentions that we're not returning nodes.ErrVirtualStorageNotExist
to avoid breaking the API contract. Perhaps we need to extend glerrors
to include ErrVirtualStorageNotExist
as the current experience is difficult for admins to debug.
/cc @8bitlife
Edited by Will Chandler (ex-GitLab)