[Feature flag] Enable GoResolveConflicts for ConflictService RPC ResolveConflicts
What
Remove the gitaly_go_resolve_conflicts
feature flag to make the new Go implementation the standard.
Owners
- Team: Gitaly
- Most appropriate slack channel to reach out to:
#g_create_gitaly
- Best individual to reach out to: Paul Okstad (@pokstad1)
Expectations
What release does this feature occur in first?
### What are we expecting to happen?
Memory usage and initial start time should improve since we are using a Go implementation. Reliability is also expected to improve since most of the complex logic is moved to a short-lived process that will not impact other requests during failures.
What might happen if this goes wrong?
There may be some unaccounted edge cases in the expected behavior from the current gitlab-rails client. We will need to monitor errors carefully and add test coverage as needed.
What can we monitor to detect problems with this?
Roll Out Steps
-
Read the documentation of feature flags -
Add featureflagstaging to this issue -
Enable on staging -
Test on staging -
Ensure that documentation has been updated -
Announce on the issue an estimated time this will be enabled on GitLab.com -
Add featureflagproduction to this issue -
Enable on GitLab.com by running chatops command in #production
-
Cross post chatops slack command to #support_gitlab-com
and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
Close this issue
Edited by Zeger-Jan van de Weg