Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitaly
gitaly
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 632
    • Issues 632
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 38
    • Merge Requests 38
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • gitalygitaly
  • Issues
  • #323

Closed
Open
Opened Jun 20, 2017 by Jacob Vosmaer@jacobvosmaer-gitlabOwner4 of 4 tasks completed4/4 tasks

Conversation: CommitService::CommitStats

Gitlab::Git::CommitStats.new


Stages:

  • RPC Design: gitaly-proto!39 (merged)

  • Server Implementation: #480 (closed) !212 (merged)

  • ~"Client Implementation": #519 (closed) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14077

  • ~"Acceptance Testing": #539 (closed)

RPC Endpoints:

  • Endpoint::Name

Known Client Routes:

  • Known client endpoints

See Gitlab::Git::CommitStats.new

https://gitlab.com/gitlab-org/gitlab-ce/blob/40cd50829944db38fac07014e5fa00eafa3d1bc7/lib/gitlab/git/commit_stats.rb#L9-23

Gitlab::Git::CommitStats.new needs to change its signature so we can pass in a Gitlab::Git::Repository instance Gitlab::Git::CommitStats.new(repo, commit)

service CommitService {
  rpc CommitStats(CommitStatsRequest) returns (CommitStatsResponse) {}
}

message CommitStatsRequest {
  Repository repository = 1;
  bytes revision = 2;
}

message CommitStatsResponse {
  string oid = 1; // OID of the commit. Empty means not found.
  int32 additions = 2;
  int32 deletions = 3;
}

Current Status

This will be ported to Gitaly-Ruby and is blocked on the progress of that work stream.

Edited Nov 24, 2017 by Zeger-Jan van de Weg
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
v1.0
Milestone
v1.0 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitaly#323